Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose new module targets in Project properties and build targets #3033

Closed
8 tasks done
mhegazy opened this issue May 5, 2015 · 3 comments
Closed
8 tasks done

Expose new module targets in Project properties and build targets #3033

mhegazy opened this issue May 5, 2015 · 3 comments
Assignees
@paulvanbrenk
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Visual Studio Integration with Visual Studio
Milestone
TypeScript 1.5.3

Comments

@mhegazy
Copy link
Contributor

mhegazy commented May 5, 2015

We have added two new module targets, umd and system, we need to expose both in:

  • Project properties in C#/VB project -- Dev12
  • Project properties in C#/VB project -- Dev14
  • Project properties in JSProj project -- Dev12
  • Project properties in JSProj project -- Dev14
  • build targets -- Dev12
  • build targets -- Dev14
  • tools\options page -- Dev12
  • tools\options page -- Dev14

One thing to figure out, is if TypeScriptToolsVersion is below 1.5, do we still pass in the module value, should it be an error?
@mhegazy mhegazy added Bug A bug in TypeScript Visual Studio Integration with Visual Studio labels May 5, 2015
@mhegazy mhegazy added this to the TypeScript 1.5.2 milestone May 5, 2015
@mhegazy mhegazy mentioned this issue May 5, 2015
Closed
14 tasks
@mhegazy
Copy link
Contributor Author

mhegazy commented May 5, 2015

updates to expose new flags tracked by #3034

@mhegazy mhegazy assigned paulvanbrenk and unassigned vladima May 6, 2015
@paulvanbrenk
Copy link
Contributor

We allow the user to specify unsupported modules even if they target an older version of the compiler, the compiler will display a useful error when that happens.

@paulvanbrenk paulvanbrenk added the Fixed A PR has been merged for this issue label May 19, 2015
@paulvanbrenk
Copy link
Contributor

Should be in 1.5 RTM for VS 2013 and VS 2015

@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@paulvanbrenk paulvanbrenk

Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue Visual Studio Integration with Visual Studio
Projects
None yet
Milestone
TypeScript 1.5.3
Development

No branches or pull requests
3 participants
@paulvanbrenk @mhegazy @vladima