Skip to content

Quick fix to convert @typedef to type or interface #31500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
5 tasks done
danvk opened this issue May 21, 2019 · 2 comments
Open
5 tasks done

Quick fix to convert @typedef to type or interface #31500

danvk opened this issue May 21, 2019 · 2 comments
Labels
Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Suggestion An idea for TypeScript

Comments

@danvk
Copy link
Contributor

danvk commented May 21, 2019

Search Terms

  • typedef quickfix
  • typedef jsdoc

Suggestion

I have lots of code in an old Closure Compiler-style project that looks like this:

/**
 * @typedef {{
 *   px: number,
 *   py: number,
 *   isZooming: boolean,
 *   isPanning: boolean,
 *   is2DPan: boolean,
 *   cancelNextDblclick: boolean,
 *   initializeMouseDown: (e: !Event, dygraph:!DygraphAny, context: !DygraphInteractionContext) => void
 * }} DygraphInteractionContext
 */

If I declare a variable with this type, I can see that TypeScript understands the @typedef:

type DygraphInteractionContext = {
    px: number;
    py: number;
    isZooming: boolean;
    isPanning: boolean;
    is2DPan: boolean;
    cancelNextDblclick: boolean;
    initializeMouseDown: (e: Event, dygraph: any, context: ...) => void;
}

I'd like to convert this to a type or interface. I can introduce a dummy variable, copy the TS-style type declaration and paste it in to do the conversion.

But it'd be easier if there were a quickfix!

Use Cases

Migrating a project that used JSDoc-based typing. A workaround is available, but a quickfix would be a big improvement.

Examples

(see above)

Checklist

My suggestion meets these guidelines:

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.
@RyanCavanaugh RyanCavanaugh added Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Suggestion An idea for TypeScript labels Jun 13, 2019
@mazyvan
Copy link

mazyvan commented Nov 20, 2020

Migrating from JS with JSdocs to TS should be better. Changing all of those annotations with real TS type declarations takes a lot of time.

https://stackoverflow.com/questions/64935099/how-to-make-typescript-infer-data-type-from-jsdocs

@egorio
Copy link
Contributor

egorio commented Jun 7, 2023

Seems, it's covered by #51430

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting More Feedback This means we'd like to hear from more people who would be helped by this feature Suggestion An idea for TypeScript
Projects
None yet
Development

No branches or pull requests

4 participants