Bug: Expand Selection (smartSelect.expand) broken in Template Strings

[alexilyaev]

Info

Issue Type: Bug
VS Code version: Code - Insiders 1.37.0-insider (5e08ee01b7daee99cdda2456f19d77e715fb8762, 2019-08-05T21:16:01.319Z)
OS version: Darwin x64 18.6.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_deferred_display_list: disabled_off skia_renderer: disabled_off surface_synchronization: enabled_on video_decode: enabled viz_display_compositor: disabled_off webgl: enabled webgl2: enabled
Load (avg)	2, 2, 2
Memory (System)	16.00GB (0.83GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions: none

Steps to Reproduce:

1. Given code block

const fox = `The quick brown ${'fox'} jumps over the lazy dog`;

2. Put the cursor anywhere after the placeholder (expressions in the middle), e.g. on "lazy"
3. Invoke "Expand Selection" twice

Expected

Should select "lazy" and then the whole string without the quotes.

Actual

Selects "lazy" and then the whole line.

Notes

• Anywhere before the placeholder works as expected
• Inside the placeholder works as expected as well

Bonus Bug

1. Given code

const fox = 'fox';
return `The quick brown ${fox} jumps over the lazy dog`;

2. Select the fox variable reference inside the template string with the mouse or with the keyboard (e.g. Shift > RightArrow)
3. Invoke "Expand Selection"

Expected

Should select the whole string without the quotes

Actual

Selects the whole line.

Notes

• If just putting the cursor on fox, then expand selection works ok.

[mjbvz]

Confirmed with TS 3.6.0-dev.20190810