Skip to content

Fourslash server tests silently ignore compiler option directives #33019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
andrewbranch opened this issue Aug 21, 2019 · 0 comments
Open

Fourslash server tests silently ignore compiler option directives #33019

andrewbranch opened this issue Aug 21, 2019 · 0 comments
Labels
Infrastructure Issue relates to TypeScript team infrastructure

Comments

@andrewbranch
Copy link
Member

The existing working solution is to create a tsconfig.json fourslash-file, which is probably a better way to do things given that the server tests are supposed to mimic reality more closely, so my proposal would be to throw early when double-slash-attersand compiler directives are encountered.

Semi-related: #25081
@andrewbranch andrewbranch added the Infrastructure Issue relates to TypeScript team infrastructure label Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewbranch