Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected compile / type error when using Promise.all #35136

Closed
jeremywen3 opened this issue Nov 16, 2019 · 2 comments · Fixed by #45350
Closed

Unexpected compile / type error when using Promise.all #35136

jeremywen3 opened this issue Nov 16, 2019 · 2 comments · Fixed by #45350
Labels
Duplicate An existing issue was already created Fix Available A PR has been opened for this issue

Comments

@jeremywen3
Copy link

TypeScript Version: 3.7.2

Search Terms:

  • Promise.all typing

Code

index.ts

type RandomType = {};

const getRandomValue = async (): Promise<RandomType> => {
    return {};
};

const getResults = async (): Promise<{ data: string[] }> => {
    return { data: ['a', 'b', 'c'] };
};

const run = async () => {
    const [random, { data }] = await Promise.all([getRandomValue(), getResults()]);
    console.log(random, data);
};

run();

tsconfig.json

{
    "compilerOptions": {
        "target": "esnext",
        "lib": ["esnext", "dom"]
    },
    "exclude": ["node_modules"],
    "include": ["./**/*.ts"]
}

Expected behavior:
Compiles successfully.

Actual behavior:
Compile error: "Property 'data' does not exist on type 'RandomType'."

Seems to still compile the js file even though it shows a compile error.

Does not run with ts-node though.

Playground Link:
http://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=13&pc=31#

Related Issues:

@MartinJohns
Copy link
Contributor

Duplicate of #34925.

@typescript-bot
Copy link
Collaborator

This issue has been marked as a 'Duplicate' and has seen no recent activity. It has been automatically closed for house-keeping purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate An existing issue was already created Fix Available A PR has been opened for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants