Skip to content

Should navto search opening projects like find all refs to give better info about world or just existing open projects #39732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sheetalkamat opened this issue Jul 24, 2020 · 2 comments
Labels
In Discussion Not yet reached consensus Suggestion An idea for TypeScript

Comments

@sheetalkamat
Copy link
Member

Yes VS Code now searches all open projects by default (on TS 3.9+). My understand is that this should only search the already opened project and not trigger a new project loads. You can disable this behavior with typescript.workspaceSymbols.scope .

I made this the default because I felt searching all projects made the most sense for the way we describe go to symbol in workspace. It is useful in the VS Code codebase for example because we usually want search results from both our extensions and our core codebase.

@amcasey VS Code cannot stream in results. We have to return them all in a single response

Originally posted by @mjbvz in #38491 (comment)

@sheetalkamat sheetalkamat changed the title Navto should search opening projects or just already open projects Should navto search opening projects like find all refs to give better info about world or just existing open projects Jul 24, 2020
@sheetalkamat
Copy link
Member Author

@amcasey
Copy link
Member

amcasey commented Jul 24, 2020

Thanks for filing this!

@RyanCavanaugh RyanCavanaugh added In Discussion Not yet reached consensus Suggestion An idea for TypeScript labels Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Discussion Not yet reached consensus Suggestion An idea for TypeScript
Projects
None yet
Development

No branches or pull requests

3 participants