Skip to content

Suggestion not shown but parameter hints do show in JS file #43647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mjbvz opened this issue Apr 12, 2021 · 3 comments
Closed

Suggestion not shown but parameter hints do show in JS file #43647

mjbvz opened this issue Apr 12, 2021 · 3 comments
Labels
Working as Intended The behavior described is the intended behavior; this is not a bug

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Apr 12, 2021

  • VS Code Version: 1.55.1
  • OS Version: Windows 20h2

From #43646

const elementsContainer = document.querySelectorAll('ul');
elementsContainer.forEach((e) => {
    e.addEventListener('dragenter', (e) => {
      e.currentTarget.
    });
});
  1. Try triggering suggestions for closest

3

@mjbvz
Copy link
Contributor Author

mjbvz commented Apr 12, 2021

The type of e is any which is why you don't see suggestions

The parameter hints have looser symbol resolving logic. This came up with one of the Math symbols before. I think we should consider disabling as I'm not sure how helpful it actually is

@andrewbranch
Copy link
Member

Isn’t this an example of it working exactly how it’s supposed to work? e.currentTarget very likely is an Element. We don’t always get these right, but this seems like a demonstration of the value proposition of the feature, not a bug.

@andrewbranch andrewbranch added the Working as Intended The behavior described is the intended behavior; this is not a bug label Apr 16, 2021
@typescript-bot
Copy link
Collaborator

This issue has been marked 'Working as Intended' and has seen no recent activity. It has been automatically closed for house-keeping purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Working as Intended The behavior described is the intended behavior; this is not a bug
Projects
None yet
Development

No branches or pull requests

3 participants