Skip to content

server doesn't watch for file add/remove #5076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jrieken opened this issue Oct 2, 2015 · 3 comments
Closed

server doesn't watch for file add/remove #5076

jrieken opened this issue Oct 2, 2015 · 3 comments
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@jrieken
Copy link
Member

jrieken commented Oct 2, 2015

@dbaeumer
Copy link
Member

dbaeumer commented Oct 2, 2015

The interesting case here is the tsconfig.json which defines the project scope. Reloading the project in this case is an 'overkill' since all that needs to be done is to add/remove files to/from the project. IMO the tsserver should either handle that case correctly or should give up on file watching and rely on the editor to provide the file events.

@mhegazy
Copy link
Contributor

mhegazy commented Oct 2, 2015

@zhengbli is working on a fix for this as part of #4553 and #4643

@mhegazy mhegazy added the Bug A bug in TypeScript label Oct 2, 2015
@mhegazy mhegazy added this to the TypeScript 1.7 milestone Oct 2, 2015
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Oct 15, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Oct 15, 2015

@jrieken can you give this a try..

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

4 participants