Node.js-like module resolution doesn't follow parent paths

[heycalmdown]

When I have following environment

• parent
  • node_modules
    • my-proper-external-module
      • index.d.ts
      • index.js
  • my-application
    • index.ts (import m_p_e_m from 'my-proper-external-module')

It couldn't resolve where the my-proper-external-module is.

It should work according the proposal (#2338) and the source code(https://github.com/Microsoft/TypeScript/blob/b95e1ff6d8656693c80ac54a15893c3ad4859762/src/compiler/program.ts#L125).

I think it's come from by the directory which the loadModuleFromNodeModules have is empty string. It is an empty so it can not follow recursively.

Below is my tsconfig.json

{
  "compilerOptions": {
    "target": "ES5",
    "module": "commonjs",
    "moduleResolution": "node"
  },
  "files": [
    "./a.ts"
  ]
}

[heycalmdown]

Got it.

When if I compile like this

tsc --project .

doesn't work. But when if

tsc --project $(pwd)

works.

[mhegazy]

looks like this is fixed in master. can you give typescript@next a try?

[heycalmdown]

Doesn't work for me

https://github.com/heycalmdown/typescript-5102/tree/master

[alexeagle]

Same issue with some angular2 users who put their tsconfig.json under a src folder.
Workaround is to run tsc from the parent directory and use the -p flag.

[mhegazy]

should be handled by #5275

[vladima]

fixed in e811fec

[mhegazy]

@alexeagle and @heycalmdown can you give tomorrow's typescript@next a try?

[heycalmdown]

Sure, I was waiting your go sign.