Feature request: publish git release tags during NPM package release process

[jayaddison]

Suggestion

🔍 Search Terms

git tag release

✅ Viability Checklist

My suggestion meets these guidelines:

• This wouldn't be a breaking change in existing TypeScript/JavaScript code
• This wouldn't change the runtime behavior of existing JavaScript code
• This could be implemented without emitting different JS based on the types of the expressions
• This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
• This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

As part of the process for release of typescript packages to NPM, push a corresponding git tag to this repository.

📃 Motivating Example

Version 4.9.3 of typescript is currently available on NPM and it is not immediately clear what git commit version that corresponds to in this repository.

💻 Use Cases

This would be useful during dependency and upgrade review - for example, when looking for potential functionality, compatibility, performance, security and transitive dependency implications of a version upgrade.

With the current approach, git tags are published, although that occurs some variable amount of time after package publication to NPM taken place. It's possible that some users do upgrade before a git tag is published -- and it's also possible that they could review the contents of the release themselves to perform non-source-controlled review.

[freeatnet]

Something must have broken in the release process, as there seems to be no GitHub release and no release notes.

[RyanCavanaugh]

This is supposed to be automatic (you can see git tags for all the prior releases) but something must have broken recently.

[weswigham]

@DanielRosenwasser do you wanna add "Review and undraft the automatically made github release" to the release handbook? 😂 We have a draft release over here just waiting for someone to check it over and undraft it, and I believe publishing that triggers the git tag, too.

[weswigham]

(Actually, literally every 4.9 release is sitting in draft state, waiting for human review T.T )

[jayaddison]

Thanks @RyanCavanaugh @weswigham - I see the 4.9.3 tag now 👍

It depends on what works for your checklists and processes, but I've found that configuring GitHub Actions to publish-on-(tag|release) can be useful -- basically providing some level of linkage between the tag/release and the published package.

One tricky aspect is handling build/infrastructure failures gracefully, and/or testing the publication workflow before a 'live' package release. I don't know what NPM offers there, but in the Python ecosystem, PyPi provides a 'test' instance so that the entire package build and upload process can be checked before go-live.

[weswigham]

It's all really automated, it's just the UI on the release queue screen isn't great for editing a large blob of markdown, so the pipeline makes the release as a draft so a human can go edit the non-final GitHub release copy template with missing information and click "undraft". We now have a reminder on the job queue page that it needs to be done just after it's queued. 😅

If anyone from azure pipelines/GitHub actions is reading this by pure chance: queue time variable fields with configurable input box types and a markdown input box type would be a nice enhancement.

[jayaddison]

Thanks @weswigham - manual edits to the markup for releases displayed on GitHub makes sense -- and for a popular package, manual review steps in general seems sensible too!

Either way, if git tags could be pushed and made visible in the repository here during the package publication process to NPM, that could help users and developers to save time inspecting the differences between versions.

[per1234]

@weswigham please consider reopening. 4.9.5 was published hours ago and there still isn't a tag.

Related:

• Unexpected 5.3.2 version tagged on npm #56473
• Missing 4.2.4 git tag #43619
• Missing 4.1.3 version Git tag #41967
• Missing 3.9.6 version Git tag #39444
• 3.7.2 tag/release missing in Git(Hub) #34946
• 3.7.2 released on npm #34921
• Was v3.6.2 released on npm on accident? #33122
• TypeScript 3.5.2 release missing from GitHub releases/tags #31903
• TypeScript 3.5.1 isn't tagged on this GitHub repo #31693
• Is Typescript V3.0.3 actually legit? #26768
• TypeScript 2.4.2 release missing from GitHub releases/tags #17487
• 2.0.3 is latest #11061

[per1234]

@weswigham please consider reopening. 5.0.3 was published hours ago and there still isn't a tag.

[per1234]

@weswigham please consider reopening. 5.1.6 was published days ago and there still isn't a tag (#54881).

[per1234]

Once again we have the problem of a package release having been published without the maintainers creating a Git tag.

@ahejlsberg @sandersn @andrewbranch @RyanCavanaugh @DanielRosenwasser @jakebailey please reopen this issue. There is clear evidence that your current system doesn't work.

[per1234]

Once again we have the problem of the 5.8.3 package release having been published without the maintainers creating a Git tag.

@ahejlsberg @sandersn @andrewbranch @RyanCavanaugh @DanielRosenwasser @jakebailey please reopen this issue. There is clear evidence that your current system doesn't work.