Skip to content

transpileModule fails when declarationMap is specified #59641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dragomirtitian opened this issue Aug 15, 2024 · 6 comments Β· Fixed by #59642
Closed

transpileModule fails when declarationMap is specified #59641

dragomirtitian opened this issue Aug 15, 2024 · 6 comments Β· Fixed by #59642
Labels
Duplicate An existing issue was already created

Comments

@dragomirtitian
Copy link
Contributor

πŸ”Ž Search Terms

transpileModule declarationMap

πŸ•— Version & Regression Information

  • This changed between versions 5.4 and 5.5

⏯ Playground Link

No response

πŸ’» Code

No response

πŸ™ Actual behavior

When calling transpileModule with options that specify both declaration and declarationMap, transpileModule will force to false declaration but will leave declarationMap as is resulting in the error: error TS5069: Option 'declarationMap' cannot be specified without specifying option 'declaration' or option 'composite'.

πŸ™‚ Expected behavior

transpileModule should set both declaration and declarationMap to false (or neither)

Additional information about the issue

No response

@jakebailey
Copy link
Member

Technically a dupe of #31991 but it's been a while

@dragomirtitian
Copy link
Contributor Author

dragomirtitian commented Aug 15, 2024

I honestly searched for an existing bug but did not find it :(

It's strange that this is newly impacting us. We did not have an issue before 5.5 RTM.

@jakebailey
Copy link
Member

jakebailey commented Aug 15, 2024

I only found that issue last night because I sorted all issues by least recently modified to find closable/interesting issues πŸ˜…

(But searching "transpileModule declarationMap" also worked)

@jakebailey
Copy link
Member

It's strange that this is newly impacting us. We did not have an issue before 5.5 RTM.

I'd suspect it was #58261

@dragomirtitian
Copy link
Contributor Author

It's strange that this is newly impacting us. We did not have an issue before 5.5 RTM.

I'd suspect it was #58261

Yeah probably. I also though so, that's why I searched for newest issues instead of going back to 2019. I was convinced it's a recent regression.

@RyanCavanaugh RyanCavanaugh added the Duplicate An existing issue was already created label Aug 15, 2024
@jakebailey
Copy link
Member

My guess would be that it was actually "fixed" a while ago, then re-broken again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants