Add types for String.{matchAll,replaceAll} with a well known symbol

[segevfiner]

⚙ Compilation target

es2022

⚙ Library

ES2023

Missing / Incorrect Definition

Definitions for String.{matchAll,replaceAll} with an object that implements [Symbol.matchAll]/[Symbol.replace], rather than a pure RegExp.

Sample Code

const someObjectThatImplementsTheSymbols = ...; // e.g. https://github.com/segevfiner/node-pcre2
"foo".matchAll(someObjectThatImplementsTheSymbols);
"foo".replaceAll(someObjectThatImplementsTheSymbols, "bar");

Documentation Link

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/matchAll
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/replaceAll

[bakkot]

Oh jeeze what if you just didn't add this so that people wouldn't use this absolutely cursed part of the language.

[petamoriken]

The corresponding RegExp Well-known Symbols are as follows:

String methods	Corresponding RegExp Well-known Symbols
String.prototype.match	Symbol.match
String.prototype.matchAll	Symbol.matchAll
String.prototype.replace	Symbol.replace
String.prototype.replaceAll	Symbol.replace（ditto）
String.prototype.search	Symbol.search
String.prototype.split	Symbol.split

It seems that the types have already been added except for String.prototype.{matchAll, replaceAll}.

[segevfiner]

Exactly. Those were simply added in later ES versions and seems to have been forgotten. I made a PR to add them. But I think I need to update some tests to complete it.