Skip to content

Use Path for all filenames in tsserver and other places #6479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zhengbli opened this issue Jan 14, 2016 · 1 comment
Closed

Use Path for all filenames in tsserver and other places #6479

zhengbli opened this issue Jan 14, 2016 · 1 comment
Assignees
@zhengbli
Labels
Infrastructure Issue relates to TypeScript team infrastructure Won't Fix The severity and priority of this issue do not warrant the time or complexity needed to fix it
Milestone
TypeScript 2.1

Comments

@zhengbli
Copy link
Contributor

Now with the dedicated Path type (#5462), we should be able to minimize the number of normalization in tsserver by changing all the file name strings to the Path type. We also have many duplicated file name normalization in program.ts and other places.
@zhengbli zhengbli changed the title Use Path for all filenames in tsserver and possibly command line parser Use Path for all filenames in tsserver and other places Jan 14, 2016
@mhegazy mhegazy added the Infrastructure Issue relates to TypeScript team infrastructure label Jan 14, 2016
@mhegazy mhegazy added the Bug A bug in TypeScript label Jan 14, 2016
@zhengbli
Copy link
Contributor Author

From the recent discussion over the case sensitivity, using Path every where is probably not a good idea. For example, when dealing with file systems directly, it is safer just to use what provided by the system, because we can't be confident in the case sensitivity in current location, which can differ from volume to volume and folder to folder. Closing this now.

@zhengbli zhengbli removed the Bug A bug in TypeScript label Mar 23, 2016
@mhegazy mhegazy added the Won't Fix The severity and priority of this issue do not warrant the time or complexity needed to fix it label Mar 23, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zhengbli zhengbli

Labels
Infrastructure Issue relates to TypeScript team infrastructure Won't Fix The severity and priority of this issue do not warrant the time or complexity needed to fix it
Projects
None yet
Milestone
TypeScript 2.1
Development

No branches or pull requests
2 participants
@zhengbli @mhegazy