From 99ff3dfedf3d68aaba8a8ec37033dea6d4de2214 Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Wed, 2 Apr 2025 16:35:15 -0700 Subject: [PATCH 1/5] Attempt to fix publishing --- azure-pipelines.release-publish.yml | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/azure-pipelines.release-publish.yml b/azure-pipelines.release-publish.yml index c928166efb115..1152837dd9a2e 100644 --- a/azure-pipelines.release-publish.yml +++ b/azure-pipelines.release-publish.yml @@ -1,15 +1,25 @@ trigger: none pr: none +parameters: + - name: _REMINDER + default: Review & undraft the release at https://github.com/microsoft/TypeScript/releases once it appears! + - name: PUBLISH_TAG + default: dev + - name: RELEASE_TITLE_NAME + default: 0.0.0 Test + - name: TAG_NAME + default: v0.0.0-SetMe + variables: - name: _REMINDER - value: Review & undraft the release at https://github.com/microsoft/TypeScript/releases once it appears! + value: ${{ parameters._REMINDER }} - name: PUBLISH_TAG - value: dev + value: ${{ parameters.PUBLISH_TAG }} - name: RELEASE_TITLE_NAME - value: 0.0.0 Test + value: ${{ parameters.RELEASE_TITLE_NAME }} - name: TAG_NAME - value: v0.0.0-SetMe + value: ${{ parameters.TAG_NAME }} resources: pipelines: From 1eb74e5a43d2403f65511fed933686a707574899 Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Fri, 4 Apr 2025 11:28:15 -0700 Subject: [PATCH 2/5] typos --- azure-pipelines.release-publish.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/azure-pipelines.release-publish.yml b/azure-pipelines.release-publish.yml index 1152837dd9a2e..407ab0605b8cc 100644 --- a/azure-pipelines.release-publish.yml +++ b/azure-pipelines.release-publish.yml @@ -78,6 +78,7 @@ extends: workingDir: $(Pipeline.Workspace)/tgz verbose: false customCommand: publish $(Pipeline.Workspace)/tgz/typescript.tgz --tag $(PUBLISH_TAG) + # This must match the service connection. customEndpoint: Typescript NPM publishEndpoint: Typescript NPM @@ -101,6 +102,7 @@ extends: - task: GitHubRelease@1 displayName: GitHub release (create) inputs: + # This must match the service connection. gitHubConnection: typescript-bot connection repositoryName: microsoft/TypeScript tagSource: userSpecifiedTag @@ -111,7 +113,7 @@ extends: For release notes, check out the [release announcement](). For new features, check out the [What's new in TypeScript $(TAG_NAME)](). For the complete list of fixed issues, check out the - * [fixed issues query for Typescript $(TAG_NAME)](https://github.com/microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+3.3%22+is%3Aclosed+). + * [fixed issues query for TypeScript $(TAG_NAME)](https://github.com/microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+3.3%22+is%3Aclosed+). Downloads are available on: * [npm](https://www.npmjs.com/package/typescript) assets: $(Pipeline.Workspace)/tgz/**/typescript-*.tgz From ca281cebc654abd3d3f6d7b6fedb67eb22ee95e0 Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Fri, 4 Apr 2025 11:35:21 -0700 Subject: [PATCH 3/5] Just make it print --- azure-pipelines.release-publish.yml | 100 +++++++++++++++------------- 1 file changed, 54 insertions(+), 46 deletions(-) diff --git a/azure-pipelines.release-publish.yml b/azure-pipelines.release-publish.yml index 407ab0605b8cc..49a45e0d2baf3 100644 --- a/azure-pipelines.release-publish.yml +++ b/azure-pipelines.release-publish.yml @@ -71,51 +71,59 @@ extends: pushd $(Pipeline.Workspace)/tgz ls -lhR mv typescript-*.tgz typescript.tgz - - task: Npm@1 - displayName: npm publish tarball + - task: CmdLine@2 + displayName: Rename versioned drop to typescript.tgz inputs: - command: custom - workingDir: $(Pipeline.Workspace)/tgz - verbose: false - customCommand: publish $(Pipeline.Workspace)/tgz/typescript.tgz --tag $(PUBLISH_TAG) - # This must match the service connection. - customEndpoint: Typescript NPM - publishEndpoint: Typescript NPM + script: | + echo ${_REMINDER} + echo ${PUBLISH_TAG} + echo ${RELEASE_TITLE_NAME} + echo ${TAG_NAME} + # - task: Npm@1 + # displayName: npm publish tarball + # inputs: + # command: custom + # workingDir: $(Pipeline.Workspace)/tgz + # verbose: false + # customCommand: publish $(Pipeline.Workspace)/tgz/typescript.tgz --tag $(PUBLISH_TAG) + # # This must match the service connection. + # customEndpoint: Typescript NPM + # publishEndpoint: Typescript NPM - - stage: Stage_2 - displayName: Publish git tag - dependsOn: Stage_1 - jobs: - - job: Job_1 - displayName: Agent job - condition: succeeded() - timeoutInMinutes: 0 - templateContext: - type: releaseJob - isProduction: true - inputs: - - input: pipelineArtifact - pipeline: 'tgz' - artifactName: 'tgz' - targetPath: '$(Pipeline.Workspace)/tgz' - steps: - - task: GitHubRelease@1 - displayName: GitHub release (create) - inputs: - # This must match the service connection. - gitHubConnection: typescript-bot connection - repositoryName: microsoft/TypeScript - tagSource: userSpecifiedTag - tag: $(TAG_NAME) - title: TypeScript $(RELEASE_TITLE_NAME) - releaseNotesSource: inline - releaseNotesInline: | - For release notes, check out the [release announcement](). - For new features, check out the [What's new in TypeScript $(TAG_NAME)](). - For the complete list of fixed issues, check out the - * [fixed issues query for TypeScript $(TAG_NAME)](https://github.com/microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+3.3%22+is%3Aclosed+). - Downloads are available on: - * [npm](https://www.npmjs.com/package/typescript) - assets: $(Pipeline.Workspace)/tgz/**/typescript-*.tgz - isDraft: true - addChangeLog: false + # - stage: Stage_2 + # displayName: Publish git tag + # dependsOn: Stage_1 + # jobs: + # - job: Job_1 + # displayName: Agent job + # condition: succeeded() + # timeoutInMinutes: 0 + # templateContext: + # type: releaseJob + # isProduction: true + # inputs: + # - input: pipelineArtifact + # pipeline: 'tgz' + # artifactName: 'tgz' + # targetPath: '$(Pipeline.Workspace)/tgz' + # steps: + # - task: GitHubRelease@1 + # displayName: GitHub release (create) + # inputs: + # # This must match the service connection. + # gitHubConnection: typescript-bot connection + # repositoryName: microsoft/TypeScript + # tagSource: userSpecifiedTag + # tag: $(TAG_NAME) + # title: TypeScript $(RELEASE_TITLE_NAME) + # releaseNotesSource: inline + # releaseNotesInline: | + # For release notes, check out the [release announcement](). + # For new features, check out the [What's new in TypeScript $(TAG_NAME)](). + # For the complete list of fixed issues, check out the + # * [fixed issues query for TypeScript $(TAG_NAME)](https://github.com/microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+3.3%22+is%3Aclosed+). + # Downloads are available on: + # * [npm](https://www.npmjs.com/package/typescript) + # assets: $(Pipeline.Workspace)/tgz/**/typescript-*.tgz + # isDraft: true + # addChangeLog: false From 25c18bdf47022daba50cd2e91b327f4a72b1a19f Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Fri, 4 Apr 2025 11:44:35 -0700 Subject: [PATCH 4/5] no checkout --- azure-pipelines.release-publish.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/azure-pipelines.release-publish.yml b/azure-pipelines.release-publish.yml index 49a45e0d2baf3..1141f1bf3c6c1 100644 --- a/azure-pipelines.release-publish.yml +++ b/azure-pipelines.release-publish.yml @@ -64,6 +64,7 @@ extends: artifactName: 'tgz' targetPath: '$(Pipeline.Workspace)/tgz' steps: + - checkout: none - task: CmdLine@2 displayName: Rename versioned drop to typescript.tgz inputs: @@ -107,6 +108,7 @@ extends: # artifactName: 'tgz' # targetPath: '$(Pipeline.Workspace)/tgz' # steps: + # - checkout: none # - task: GitHubRelease@1 # displayName: GitHub release (create) # inputs: From 30b66a0f66ed4759490269953de8717b5979d4ef Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Fri, 4 Apr 2025 11:49:54 -0700 Subject: [PATCH 5/5] alrighty --- azure-pipelines.release-publish.yml | 102 +++++++++++++--------------- 1 file changed, 47 insertions(+), 55 deletions(-) diff --git a/azure-pipelines.release-publish.yml b/azure-pipelines.release-publish.yml index 1141f1bf3c6c1..2f3aac21446cc 100644 --- a/azure-pipelines.release-publish.yml +++ b/azure-pipelines.release-publish.yml @@ -72,60 +72,52 @@ extends: pushd $(Pipeline.Workspace)/tgz ls -lhR mv typescript-*.tgz typescript.tgz - - task: CmdLine@2 - displayName: Rename versioned drop to typescript.tgz + - task: Npm@1 + displayName: npm publish tarball inputs: - script: | - echo ${_REMINDER} - echo ${PUBLISH_TAG} - echo ${RELEASE_TITLE_NAME} - echo ${TAG_NAME} - # - task: Npm@1 - # displayName: npm publish tarball - # inputs: - # command: custom - # workingDir: $(Pipeline.Workspace)/tgz - # verbose: false - # customCommand: publish $(Pipeline.Workspace)/tgz/typescript.tgz --tag $(PUBLISH_TAG) - # # This must match the service connection. - # customEndpoint: Typescript NPM - # publishEndpoint: Typescript NPM + command: custom + workingDir: $(Pipeline.Workspace)/tgz + verbose: false + customCommand: publish $(Pipeline.Workspace)/tgz/typescript.tgz --tag $(PUBLISH_TAG) + # This must match the service connection. + customEndpoint: Typescript NPM + publishEndpoint: Typescript NPM - # - stage: Stage_2 - # displayName: Publish git tag - # dependsOn: Stage_1 - # jobs: - # - job: Job_1 - # displayName: Agent job - # condition: succeeded() - # timeoutInMinutes: 0 - # templateContext: - # type: releaseJob - # isProduction: true - # inputs: - # - input: pipelineArtifact - # pipeline: 'tgz' - # artifactName: 'tgz' - # targetPath: '$(Pipeline.Workspace)/tgz' - # steps: - # - checkout: none - # - task: GitHubRelease@1 - # displayName: GitHub release (create) - # inputs: - # # This must match the service connection. - # gitHubConnection: typescript-bot connection - # repositoryName: microsoft/TypeScript - # tagSource: userSpecifiedTag - # tag: $(TAG_NAME) - # title: TypeScript $(RELEASE_TITLE_NAME) - # releaseNotesSource: inline - # releaseNotesInline: | - # For release notes, check out the [release announcement](). - # For new features, check out the [What's new in TypeScript $(TAG_NAME)](). - # For the complete list of fixed issues, check out the - # * [fixed issues query for TypeScript $(TAG_NAME)](https://github.com/microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+3.3%22+is%3Aclosed+). - # Downloads are available on: - # * [npm](https://www.npmjs.com/package/typescript) - # assets: $(Pipeline.Workspace)/tgz/**/typescript-*.tgz - # isDraft: true - # addChangeLog: false + - stage: Stage_2 + displayName: Publish git tag + dependsOn: Stage_1 + jobs: + - job: Job_1 + displayName: Agent job + condition: succeeded() + timeoutInMinutes: 0 + templateContext: + type: releaseJob + isProduction: true + inputs: + - input: pipelineArtifact + pipeline: 'tgz' + artifactName: 'tgz' + targetPath: '$(Pipeline.Workspace)/tgz' + steps: + - checkout: none + - task: GitHubRelease@1 + displayName: GitHub release (create) + inputs: + # This must match the service connection. + gitHubConnection: typescript-bot connection + repositoryName: microsoft/TypeScript + tagSource: userSpecifiedTag + tag: $(TAG_NAME) + title: TypeScript $(RELEASE_TITLE_NAME) + releaseNotesSource: inline + releaseNotesInline: | + For release notes, check out the [release announcement](). + For new features, check out the [What's new in TypeScript $(TAG_NAME)](). + For the complete list of fixed issues, check out the + * [fixed issues query for TypeScript $(TAG_NAME)](https://github.com/microsoft/TypeScript/issues?utf8=%E2%9C%93&q=is%3Aissue+milestone%3A%22TypeScript+3.3%22+is%3Aclosed+). + Downloads are available on: + * [npm](https://www.npmjs.com/package/typescript) + assets: $(Pipeline.Workspace)/tgz/**/typescript-*.tgz + isDraft: true + addChangeLog: false