Skip to content

Commit d2b1a7e

Browse files
Refactor design (#1059)
* refactor design section * refactor design section * uppercase README * add links * fix links
1 parent 7fc5573 commit d2b1a7e

22 files changed

+19
-45
lines changed

docs/design/design-patterns/README.md

-10
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,3 @@
33
The design patterns section recommends patterns of software and architecture design.
44
This section provides a curated list of commonly used patterns from trusted sources.
55
Rather than duplicate or replace the cited sources, this section aims to compliment them with suggestions, guidance, and learnings based on firsthand experiences.
6-
7-
## Subsections
8-
9-
* [Data Heavy Design Guidance](data-heavy-design-guidance.md)
10-
* [Object Oriented Design Reference](object-oriented-design-reference.md)
11-
* [Distributed System Design Reference](distributed-system-design-reference.md)
12-
* [REST API Design Guidance](rest-api-design-guidance.md)
13-
* [Cloud Resource Design Guidance](cloud-resource-design-guidance.md)
14-
* [Network Architecture Guidance for Azure](network-architecture-guidance-for-azure.md)
15-
* [Network Architecture Guidance for Hybrid](network-architecture-guidance-for-hybrid.md)

docs/design/design-reviews/README.md

-12
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,5 @@
11
# Design Reviews
22

3-
## Table of Contents
4-
5-
- [Goals](#goals)
6-
- [Measures](#measures)
7-
- [Impact](#impact)
8-
- [Participation](#participation)
9-
- [Facilitation Guidance](#facilitation-guidance)
10-
- [Technical Spike](#technical-spike)
11-
123
## Goals
134

145
- Reduce technical debt for our customers
@@ -53,9 +44,6 @@ There is also a healthy balancing act in supporting a healthy debate while not h
5344

5445
The dev crew should always participate in all design review sessions
5546

56-
- [ISE](../../ISE.md) Engineering
57-
- Customer Engineering
58-
5947
### Domain Experts
6048

6149
Domain experts should participate in design review sessions as needed

docs/design/design-reviews/recipes/milestone-epic-design-review-recipe.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ Design at epic/milestone level can help the team make better decisions about pri
66

77
## Things to keep in mind
88

9-
* As with all other aspects of the project, design reviews must provide a friendly and safe environment so that any team member feels comfortable proposing a design for review and can use the opportunity to grow and learn from the constructive / non-judgemental feedback from peers and subject-matter experts (see [Team Agreements](../../../agile-development/advanced-topics/team-agreements/README.md)).
9+
* As with all other aspects of the project, design reviews must provide a friendly and safe environment so that any team member feels comfortable proposing a design for review and can use the opportunity to grow and learn from the constructive / non-judgemental feedback from peers and subject-matter experts (see [Team Agreements](../../../agile-development/advanced-topics/team-agreements)).
1010
* Design reviews should be lightweight and should not feel like an additional process overhead.
1111
* Dev Lead can usually provide guidance on whether a given epic/milestone needs a design review and can help other team members in preparation.
1212
* This is *not* a strict template that must be followed and teams should not be bogged down with polished "design presentations".
@@ -16,4 +16,4 @@ Design at epic/milestone level can help the team make better decisions about pri
1616

1717
## Template
1818

19-
You can download the **[Milestone/Epic Design Review Template](./milestone-epic-design-review-template.md)**, copy it into your project, and use it as described in the [async design review recipe](./async-design-reviews.md).
19+
You can download the **[Milestone/Epic Design Review Template](./templates/milestone-epic-design-review.md)**, copy it into your project, and use it as described in the [async design review recipe](./async-design-reviews.md).

docs/design/design-reviews/recipes/feature-story-design-review-template.md renamed to docs/design/design-reviews/recipes/templates/feature-story-design-review.md

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
# Your Feature or Story Design Title Here (prefix with DRAFT/WIP to indicate level of completeness)
1+
# Template: Feature / Story Design Review
2+
3+
**Your Feature or Story Design Title Here (prefix with DRAFT/WIP to indicate level of completeness)**
24

35
> Does the feature re-use or extend existing patterns / interfaces that have already been established for the project?
46
> Does the feature expose new patterns or interfaces that will establish a new standard for new future development?
@@ -18,7 +20,7 @@
1820
## Goals/In-Scope
1921

2022
* List the goals that the feature/story will help us achieve that are most relevant for the design review discussion.
21-
* This should include acceptance criteria required to meet [definition of done](../../../agile-development/advanced-topics/team-agreements/definition-of-done.md).
23+
* This should include acceptance criteria required to meet [definition of done](../../../../agile-development/advanced-topics/team-agreements/definition-of-done.md).
2224

2325
## Non-goals / Out-of-Scope
2426

docs/design/design-reviews/recipes/milestone-epic-design-review-template.md renamed to docs/design/design-reviews/recipes/templates/milestone-epic-design-review.md

+5-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
# Your Milestone/Epic Design Title Here (prefix with DRAFT/WIP to indicate level of completeness)
1+
# Template: Milestone / Epic Design Review
22

3-
> Please refer to <https://microsoft.github.io/code-with-engineering-playbook/design/design-reviews/recipes/milestone-epic-design-review-recipe/> for things to keep in mind when using this template.
3+
**Your Milestone/Epic Design Title Here (prefix with DRAFT/WIP to indicate level of completeness)**
4+
5+
> Please refer to the [milestone/epic design review recipe](../milestone-epic-design-review-recipe.md) for things to keep in mind when using this template.
46
57
* Milestone / Epic: [Name](http://link-to-work-item)
68
* Project / Engagement: [Project Engagement]
@@ -12,7 +14,7 @@
1214
1315
## Goals / In-Scope
1416

15-
> List a few bullet points of goals that this milestone/epic will achieve and that are most relevant for the design review discussion. You may include acceptable criteria required to meet the [Definition of Done](../../../agile-development/advanced-topics/team-agreements/definition-of-done.md).
17+
> List a few bullet points of goals that this milestone/epic will achieve and that are most relevant for the design review discussion. You may include acceptable criteria required to meet the [Definition of Done](../../../../agile-development/advanced-topics/team-agreements/definition-of-done.md).
1618
1719
## Non-goals / Out-of-Scope
1820

docs/design/design-reviews/recipes/task-design-review-template.md renamed to docs/design/design-reviews/recipes/templates/template-task-design-review.md

+5-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1-
# Your Task Design Title Here (prefix with DRAFT/WIP to indicate level of completeness)
1+
# Template: Task Design Review
22

3-
> When developing a design document for a new task, it should contain a detailed design proposal demonstrating how it will solve the goals outlined below.
3+
**Your Task Design Title Here (prefix with DRAFT/WIP to indicate level of completeness)**
4+
5+
> When developing a design document for a new task, it should contain a detailed design proposal demonstrating how it will solve the goals outlined below.
46
> Not all tasks require a design review, but when they do it is likely that there many unknowns, or the solution may be more complex.
57
> The design should include diagrams, pseudocode, interface contracts as needed to provide a detailed understanding of the proposal.
68
@@ -19,7 +21,7 @@
1921
## Goals/In-Scope
2022

2123
* List a few bullet points of what this task will achieve and that are most relevant for the design review discussion.
22-
* This should include acceptance criteria required to meet the [definition of done](../../../agile-development/advanced-topics/team-agreements/definition-of-done.md).
24+
* This should include acceptance criteria required to meet the [definition of done](../../../../agile-development/advanced-topics/team-agreements/definition-of-done.md).
2325

2426
## Non-goals / Out-of-Scope
2527

docs/design/design-reviews/recipes/sprint-spike-template.md renamed to docs/design/design-reviews/recipes/templates/template-technical-spike.md

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
# Spike: {Name}
1+
# Template: Technical Spike
2+
3+
**Spike: {Name}**
24

35
- **Conducted by:** {Names and at least one email address for follow-up questions}
46
- **Backlog Work Item:** {Link to the work item to provide more context}

docs/design/readme.md

-12
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,6 @@ This covers not only technical design of software, but also architecture design
1111
- Reference or define process or checklists to help ensure well-designed software.
1212
- Collate and point to reference sources (guides, repos, articles) that can help shortcut the learning process.
1313

14-
## Sections
15-
16-
- [Diagram Types](diagram-types/README.md)
17-
- [Design Patterns](design-patterns/README.md)
18-
- [Design Reviews](design-reviews/README.md)
19-
- [Non-Functional Requirements Guidance](design-patterns/non-functional-requirements-capture-guide.md)
20-
- [Sustainable Software Engineering](sustainability/readme.md)
21-
22-
## Recipes
23-
24-
- [Design Recipes](design-reviews/recipes/README.md)
25-
2614
## Code Examples
2715

2816
- Folder Structure

0 commit comments

Comments
 (0)