Skip to content

Commit 1f2bb82

Browse files
chrdavisChris Davis
authored and
Ninad Pahune
committed
Remove extra semicolons (#1331)
Co-authored-by: Chris Davis <[email protected]>
1 parent 4132adc commit 1f2bb82

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+216
-216
lines changed

‎lib/api/AuthTokensController.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
namespace MAT_NS_BEGIN {
1111

12-
MATSDK_LOG_INST_COMPONENT_CLASS(AuthTokensController, "EventsSDK.AuthTokensController", "Events telemetry client - AuthTokensController class");
12+
MATSDK_LOG_INST_COMPONENT_CLASS(AuthTokensController, "EventsSDK.AuthTokensController", "Events telemetry client - AuthTokensController class")
1313

1414
AuthTokensController::AuthTokensController()
1515
:m_IsStrictModeEnabled(false)

‎lib/api/DataViewerCollection.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
namespace MAT_NS_BEGIN {
1010

11-
MATSDK_LOG_INST_COMPONENT_CLASS(DataViewerCollection, "EventsSDK.DataViewerCollection", "Microsoft Telemetry Client - DataViewerCollection class");
11+
MATSDK_LOG_INST_COMPONENT_CLASS(DataViewerCollection, "EventsSDK.DataViewerCollection", "Microsoft Telemetry Client - DataViewerCollection class")
1212

1313
void DataViewerCollection::DispatchDataViewerEvent(const std::vector<uint8_t>& packetData) const noexcept
1414
{
@@ -21,7 +21,7 @@ namespace MAT_NS_BEGIN {
2121
// Task 3568800: Integrate ThreadPool to IDataViewerCollection
2222
viewer->ReceiveData(packetData);
2323
}
24-
};
24+
}
2525

2626
void DataViewerCollection::RegisterViewer(const std::shared_ptr<IDataViewer>& dataViewer)
2727
{

‎lib/api/DataViewerCollection.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ namespace MAT_NS_BEGIN {
3131

3232
virtual bool IsViewerRegistered(const char* viewerName) const override;
3333

34-
virtual ~DataViewerCollection() noexcept {};
34+
virtual ~DataViewerCollection() noexcept {}
3535
private:
3636
MATSDK_LOG_DECL_COMPONENT_CLASS();
3737

‎lib/api/IRuntimeConfig.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ namespace MAT_NS_BEGIN
209209
/// </summary>
210210
virtual bool SkipIKeyRegistration() const = 0;
211211

212-
virtual ~IRuntimeConfig() {};
212+
virtual ~IRuntimeConfig() {}
213213
};
214214

215215
/// @endcond

‎lib/api/LogManagerImpl.cpp

+6-6
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ namespace MAT_NS_BEGIN
128128
return true;
129129
}
130130

131-
MATSDK_LOG_INST_COMPONENT_CLASS(LogManagerImpl, "EventsSDK.LogManager", "Microsoft Telemetry Client - LogManager class");
131+
MATSDK_LOG_INST_COMPONENT_CLASS(LogManagerImpl, "EventsSDK.LogManager", "Microsoft Telemetry Client - LogManager class")
132132

133133
#if 1
134134
// TODO: integrate Tracing API from v1
@@ -374,7 +374,7 @@ namespace MAT_NS_BEGIN
374374
client->SetMsRootCheck(m_logConfiguration[CFG_MAP_HTTP][CFG_BOOL_HTTP_MS_ROOT_CHECK]);
375375
}
376376
#endif
377-
};
377+
}
378378

379379
LogManagerImpl::~LogManagerImpl() noexcept
380380
{
@@ -541,7 +541,7 @@ namespace MAT_NS_BEGIN
541541
const std::string& LogManagerImpl::GetTransmitProfileName()
542542
{
543543
return TransmitProfiles::getProfile();
544-
};
544+
}
545545

546546
ISemanticContext& LogManagerImpl::GetSemanticContext()
547547
{
@@ -699,7 +699,7 @@ namespace MAT_NS_BEGIN
699699
void LogManagerImpl::AddEventListener(DebugEventType type, DebugEventListener& listener)
700700
{
701701
m_debugEventSource.AddEventListener(type, listener);
702-
};
702+
}
703703

704704
/// <summary>
705705
/// Removes the event listener.
@@ -709,7 +709,7 @@ namespace MAT_NS_BEGIN
709709
void LogManagerImpl::RemoveEventListener(DebugEventType type, DebugEventListener& listener)
710710
{
711711
m_debugEventSource.RemoveEventListener(type, listener);
712-
};
712+
}
713713

714714
/// <summary>
715715
/// Dispatches the event.
@@ -719,7 +719,7 @@ namespace MAT_NS_BEGIN
719719
bool LogManagerImpl::DispatchEvent(DebugEvent evt)
720720
{
721721
return m_debugEventSource.DispatchEvent(std::move(evt));
722-
};
722+
}
723723

724724
/// <summary>Attach cascaded DebugEventSource to forward all events to</summary>
725725
bool LogManagerImpl::AttachEventSource(DebugEventSource& other)

‎lib/api/LogManagerImpl.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ namespace MAT_NS_BEGIN
182182
{
183183
const std::string val(value);
184184
return SetContext(name, val, piiKind);
185-
};
185+
}
186186

187187
virtual inline status_t SetContext(const std::string& name, int8_t value, PiiKind piiKind = PiiKind_None) override
188188
{

‎lib/api/Logger.cpp

+7-7
Original file line numberDiff line numberDiff line change
@@ -175,37 +175,37 @@ namespace MAT_NS_BEGIN
175175
void Logger::SetContext(const std::string& k, const char v[], PiiKind pii)
176176
{
177177
SetContext(k, EventProperty(v, pii));
178-
};
178+
}
179179

180180
void Logger::SetContext(const std::string& k, const std::string& v, PiiKind pii)
181181
{
182182
SetContext(k, EventProperty(v, pii));
183-
};
183+
}
184184

185185
void Logger::SetContext(const std::string& k, double v, PiiKind pii)
186186
{
187187
SetContext(k, EventProperty(v, pii));
188-
};
188+
}
189189

190190
void Logger::SetContext(const std::string& k, int64_t v, PiiKind pii)
191191
{
192192
SetContext(k, EventProperty(v, pii));
193-
};
193+
}
194194

195195
void Logger::SetContext(const std::string& k, time_ticks_t v, PiiKind pii)
196196
{
197197
SetContext(k, EventProperty(v, pii));
198-
};
198+
}
199199

200200
void Logger::SetContext(const std::string& k, GUID_t v, PiiKind pii)
201201
{
202202
SetContext(k, EventProperty(v, pii));
203-
};
203+
}
204204

205205
void Logger::SetContext(const std::string& k, bool v, PiiKind pii)
206206
{
207207
SetContext(k, EventProperty(v, pii));
208-
};
208+
}
209209

210210
// The goal of this method is to rewire the logger instance to any other ISemanticContext issued by SDK.
211211
// SDK may provide a future option for a guest logger to opt-in into its own semantic context. The method will then

‎lib/config/RuntimeConfig_Default.hpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -115,14 +115,14 @@ namespace MAT_NS_BEGIN
115115
UNREFERENCED_PARAMETER(extension);
116116
UNREFERENCED_PARAMETER(experimentationProject);
117117
UNREFERENCED_PARAMETER(eventName);
118-
};
118+
}
119119

120120
virtual EventLatency GetEventLatency(std::string const& tenantId = std::string(), std::string const& eventName = std::string()) override
121121
{
122122
UNREFERENCED_PARAMETER(tenantId);
123123
UNREFERENCED_PARAMETER(eventName);
124124
return EventLatency_Normal;
125-
};
125+
}
126126

127127
virtual std::string GetMetaStatsTenantToken() override
128128
{
@@ -134,7 +134,7 @@ namespace MAT_NS_BEGIN
134134
return std::string(token);
135135
}
136136
return std::string(defaultToken);
137-
};
137+
}
138138

139139
virtual unsigned GetMetaStatsSendIntervalSec() override
140140
{
@@ -144,7 +144,7 @@ namespace MAT_NS_BEGIN
144144
virtual unsigned GetOfflineStorageMaximumSizeBytes() override
145145
{
146146
return config[CFG_INT_CACHE_FILE_SIZE];
147-
};
147+
}
148148

149149
virtual unsigned GetOfflineStorageResizeThresholdPct() override
150150
{

‎lib/decorators/BaseDecorator.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ namespace MAT_NS_BEGIN
2424

2525
public:
2626
BaseDecorator(ILogManager& owner);
27-
virtual ~BaseDecorator() {};
27+
virtual ~BaseDecorator() {}
2828
bool decorate(CsProtocol::Record& record);
2929

3030
protected:

‎lib/decorators/EventPropertiesDecorator.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ namespace MAT_NS_BEGIN {
5353
//
5454
randomLocalId = "r:";
5555
randomLocalId+= PAL::generateUuidString();
56-
};
56+
}
5757

5858
void dropPiiPartA(::CsProtocol::Record& record)
5959
{

‎lib/decorators/SemanticApiDecorators.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ namespace MAT_NS_BEGIN {
1616
class SemanticApiDecorators : public BaseDecorator {
1717

1818
public:
19-
SemanticApiDecorators(ILogManager& owner) : BaseDecorator(owner) {};
19+
SemanticApiDecorators(ILogManager& owner) : BaseDecorator(owner) {}
2020

2121
bool decorateAggregatedMetricMessage(::CsProtocol::Record& record, AggregatedMetricData const& metricData)
2222
{

‎lib/http/HttpClientFactory.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333

3434
namespace MAT_NS_BEGIN {
3535

36-
MATSDK_LOG_INST_COMPONENT_CLASS(HttpClientFactory, "EventsSDK.HttpClientFactory", "Events telemetry client - HttpClientFactory class");
36+
MATSDK_LOG_INST_COMPONENT_CLASS(HttpClientFactory, "EventsSDK.HttpClientFactory", "Events telemetry client - HttpClientFactory class")
3737

3838
#if defined(MATSDK_PAL_WIN32)
3939
#ifdef _WINRT_DLL

‎lib/http/HttpClientManager.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ namespace MAT_NS_BEGIN {
6161
// as well pass the data back by updating the data structure.
6262
DebugEvent evt(EVT_HTTP_STATE, size_t(state), 0, data, size);
6363
m_hcm.m_logManager.DispatchEvent(evt);
64-
};
64+
}
6565

6666

6767
virtual ~HttpCallback()

‎lib/http/HttpClient_WinInet.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -540,7 +540,7 @@ void HttpClient_WinInet::CancelAllRequests()
540540
PAL::sleep(100);
541541
std::this_thread::yield();
542542
}
543-
};
543+
}
544544

545545
/// <summary>
546546
/// Enforces MS-root server certificate check.

‎lib/include/mat/IDeviceInformation.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ namespace PAL_NS_BEGIN {
2424
{
2525
public:
2626

27-
virtual ~IDeviceInformation() {};
27+
virtual ~IDeviceInformation() {}
2828

2929
/// <summary>
3030
/// Gets the unique ID of the current device

‎lib/include/mat/INetworkInformation.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ namespace PAL_NS_BEGIN {
2727
{
2828
public:
2929

30-
virtual ~INetworkInformation() {};
30+
virtual ~INetworkInformation() {}
3131

3232
/// <summary>
3333
/// Gets the current network provider for the device

‎lib/include/mat/ISystemInformation.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ namespace PAL_NS_BEGIN {
1616
{
1717
public:
1818

19-
virtual ~ISystemInformation() {};
19+
virtual ~ISystemInformation() {}
2020

2121
/// <summary>
2222
/// Gets the App ID.

‎lib/include/public/CAPIClient.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ namespace MAT_NS_BEGIN
4747
{
4848
handle = evt_open(config);
4949
return handle;
50-
};
50+
}
5151

5252
evt_status_t configure(const char* config)
5353
{

‎lib/include/public/CommonFields.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,6 @@
120120
virtual void SETTER_METHOD (name) (const std::string & x) \
121121
{ \
122122
SetCommonField(placeholder, x); \
123-
};
123+
}
124124

125125
#endif

‎lib/include/public/DebugEvents.hpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -154,12 +154,12 @@ namespace MAT_NS_BEGIN
154154
size_t size;
155155

156156
/// <summary>DebugEvent The default DebugEvent constructor.</summary>
157-
DebugEvent() : seq(0), ts(0), type(EVT_UNKNOWN), param1(0), param2(0), data(NULL), size(0) {};
157+
DebugEvent() : seq(0), ts(0), type(EVT_UNKNOWN), param1(0), param2(0), data(NULL), size(0) {}
158158

159-
DebugEvent(DebugEventType type_) : seq(0), ts(0), type(type_), param1(0), param2(0), data(NULL), size(0) {};
159+
DebugEvent(DebugEventType type_) : seq(0), ts(0), type(type_), param1(0), param2(0), data(NULL), size(0) {}
160160

161161
DebugEvent(DebugEventType type_, size_t param1_, size_t param2_ = 0, void* data_ = nullptr, size_t size_ = 0) :
162-
seq(0), ts(0), type(type_), param1(param1_), param2(param2_), data(data_), size(size_) {};
162+
seq(0), ts(0), type(type_), param1(param1_), param2(param2_), data(data_), size(size_) {}
163163
};
164164

165165
/// <summary>

‎lib/include/public/IHttpClient.hpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -494,7 +494,7 @@ namespace MAT_NS_BEGIN
494494
std::ignore = state;
495495
std::ignore = data;
496496
std::ignore = size;
497-
};
497+
}
498498
};
499499

500500
/// <summary>
@@ -542,7 +542,7 @@ namespace MAT_NS_BEGIN
542542
/// <param name="id">A string that contains the ID of the request to cancel.</param>
543543
virtual void CancelRequestAsync(std::string const& id) = 0;
544544

545-
virtual void CancelAllRequests() {};
545+
virtual void CancelAllRequests() {}
546546
};
547547

548548
/// @endcond

‎lib/include/public/IModule.hpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,13 @@ namespace MAT_NS_BEGIN
2727
/// Initializes the module.
2828
/// Invoked as part of parent ILogManager is constructed.
2929
/// </summary>
30-
virtual void Initialize(ILogManager*) noexcept {};
30+
virtual void Initialize(ILogManager*) noexcept {}
3131

3232
/// <summary>
3333
/// Tears down the module.
3434
/// Invoked as part of parent ILogManager's FlushAndTeardown() method.
3535
/// </summary>
36-
virtual void Teardown() noexcept {};
36+
virtual void Teardown() noexcept {}
3737
};
3838

3939
/// @endcond

‎lib/include/public/IOfflineStorage.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ namespace MAT_NS_BEGIN {
344344

345345
virtual bool ResizeDb() = 0;
346346

347-
virtual void ReleaseAllRecords() {};
347+
virtual void ReleaseAllRecords() {}
348348

349349
};
350350

0 commit comments

Comments
 (0)