Skip to content

Commit 08809c0

Browse files
dschogitster
authored andcommitted
mingw: add a helper function to attach GDB to the current process
When debugging Git, the criss-cross spawning of processes can make things quite a bit difficult, especially when a Unix shell script is thrown in the mix that calls a `git.exe` that then segfaults. To help debugging such things, we introduce the `open_in_gdb()` function which can be called at a code location where the segfault happens (or as close as one can get); This will open a new MinTTY window with a GDB that already attached to the current process. Inspired by Derrick Stolee. Signed-off-by: Johannes Schindelin <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent b6d4d82 commit 08809c0

File tree

2 files changed

+23
-0
lines changed

2 files changed

+23
-0
lines changed

compat/mingw.c

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,19 @@
1313

1414
static const int delay[] = { 0, 1, 10, 20, 40 };
1515

16+
void open_in_gdb(void)
17+
{
18+
static struct child_process cp = CHILD_PROCESS_INIT;
19+
extern char *_pgmptr;
20+
21+
argv_array_pushl(&cp.args, "mintty", "gdb", NULL);
22+
argv_array_pushf(&cp.args, "--pid=%d", getpid());
23+
cp.clean_on_exit = 1;
24+
if (start_command(&cp) < 0)
25+
die_errno("Could not start gdb");
26+
sleep(1);
27+
}
28+
1629
int err_win_to_posix(DWORD winerr)
1730
{
1831
int error = ENOSYS;

compat/mingw.h

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -591,6 +591,16 @@ extern CRITICAL_SECTION pinfo_cs;
591591
int wmain(int argc, const wchar_t **w_argv);
592592
int main(int argc, const char **argv);
593593

594+
/*
595+
* For debugging: if a problem occurs, say, in a Git process that is spawned
596+
* from another Git process which in turn is spawned from yet another Git
597+
* process, it can be quite daunting to figure out what is going on.
598+
*
599+
* Call this function to open a new MinTTY (this assumes you are in Git for
600+
* Windows' SDK) with a GDB that attaches to the current process right away.
601+
*/
602+
extern void open_in_gdb(void);
603+
594604
/*
595605
* Used by Pthread API implementation for Windows
596606
*/

0 commit comments

Comments
 (0)