Skip to content

Commit 2e6800d

Browse files
skottmckayedgchen1
andauthored
Apply suggestions from code review
Co-authored-by: Edward Chen <[email protected]>
1 parent fdf8c6a commit 2e6800d

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

onnxruntime/core/providers/partitioning_utils.cc

+1-2
Original file line numberDiff line numberDiff line change
@@ -245,8 +245,7 @@ std::vector<std::vector<const Node*>> CreateSupportedPartitionNodeGroups(
245245
process_downstream_node(output);
246246
});
247247
} else {
248-
std::for_each(node.OutputNodesBegin(), node.OutputNodesEnd(),
249-
[&](const Node& output) { process_downstream_node(output); });
248+
std::for_each(node.OutputNodesBegin(), node.OutputNodesEnd(), process_downstream_node);
250249
}
251250

252251
++num_nodes_processed;

onnxruntime/test/providers/partitioning_utils_test.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ TEST(PartitioningUtilsTest, TestHandlingQDQNodeUnitWithNoQNodes) {
135135
}
136136

137137
// TopK produces 2 outputs, one of which is used in a QDQ node group (Q of values output)
138-
// and the other (indices output) is not. A downstream node consumuing the indices output has an edge from the target
138+
// and the other (indices output) is not. A downstream node consuming the indices output has an edge from the target
139139
// node and not a Q node.
140140
// To process this correctly, the QDQ NodeUnit must return output edges for both the Q node/s of the values output,
141141
// and the downstream node (Cast in this case) of the indices output.

0 commit comments

Comments
 (0)