feat: browser_resize #92
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new "browser_resize" tool to resize the browser window in both desktop and mobile formats, addressing issue #5.
- Added a new test for "browser_resize" in tests/basic.spec.ts
- Implemented the "browser_resize" tool logic in src/tools/common.ts
- Integrated the new tool into the main tool arrays in src/index.ts
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/basic.spec.ts | Adds tests to validate the browser_resize functionality in both desktop and mobile formats. |
| src/tools/common.ts | Implements the resize tool with input validation and processing logic. |
| src/index.ts | Updates the tool arrays to include the browser_resize tool. |
| @@ -174,3 +174,28 @@ export const chooseFile: ToolFactory = snapshot => ({ | |||
| }, snapshot); | |||
| }, | |||
| }); | |||
|
|
|||
| const resizeSchema = z.object({ | |||
There was a problem hiding this comment.
Let them specify pixels? We should be careful about exposing it as it is niche and unclear how it is going to be used. Original request wanted it for responsive design where 800 vs 1024 vs 1280 could result in different media query matches...
There was a problem hiding this comment.
done in 5699c17. was originally concerned that the LLM wouldn't use good values, but it worked well in some tests.
pavelfeldman
previously approved these changes
Mar 31, 2025
|
Sorry you need a rebase |
Co-authored-by: Copilot <[email protected]>
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5