cherry-pick(#33627): fix(codegen): document.documentElement is null on early navigation

mxschmitt · mxschmitt · commit 698823a78ee2 · 2024-11-15T17:16:41.000+01:00
diff --git a/packages/playwright-core/src/server/injected/highlight.ts b/packages/playwright-core/src/server/injected/highlight.ts
@@ -90,7 +90,8 @@ export class Highlight {
   }
 
   install() {
-    if (!this._injectedScript.document.documentElement.contains(this._glassPaneElement))
+    // NOTE: document.documentElement can be null: https://github.com/microsoft/TypeScript/issues/50078
+    if (this._injectedScript.document.documentElement && !this._injectedScript.document.documentElement.contains(this._glassPaneElement))
       this._injectedScript.document.documentElement.appendChild(this._glassPaneElement);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,8 @@ export class Highlight {`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`install() {`
`93`		`- if (!this._injectedScript.document.documentElement.contains(this._glassPaneElement))`
	`93`	`+ // NOTE: document.documentElement can be null: https://github.com/microsoft/TypeScript/issues/50078`
	`94`	`+ if (this._injectedScript.document.documentElement && !this._injectedScript.document.documentElement.contains(this._glassPaneElement))`
`94`	`95`	`this._injectedScript.document.documentElement.appendChild(this._glassPaneElement);`
`95`	`96`	`}`
`96`	`97`