Skip to content

Commit 034d815

Browse files
Lulu Wuhuntie
Lulu Wu
authored andcommitted
Add ExceptionsManagerModule for RNTester (facebook#40767)
Summary: Pull Request resolved: facebook#40767 Fix the following issue: ```Invariant Violation: TurboModuleRegistry.getEnforcing(...): 'ExceptionsManager' could not be found. Verify that a module by this name is registered in the native binary.Bridgeless mode: true. TurboModule interop: true. Modules loaded: {"NativeModules":[],"TurboModules": ["PlatformConstants","AppState","SourceCode","BlobModule","WebSocketModule","DevSettings","DevToolsSettingsManager","LogBox","Networking","Appearance","DevLoadingView","DeviceInfo","DeviceEventManager", "SoundManager","ImageLoader","DialogManagerAndroid","NativeAnimatedModule","I18nManager","AccessibilityInfo","StatusBarManager","StatusBarManager","IntentAndroid","ToastAndroid","ShareModule","Vibration"], "NotFound":["NativePerformanceCxx","NativePerformanceObserverCxx","RedBox","BugReporting","HeadlessJsTaskSupport","FrameRateLogger","KeyboardObserver", "AccessibilityManager","ModalManager","LinkingManager","ActionSheetManager","ExceptionsManager"]} ``` Changelog: [Android][Changed] - Add Add ExceptionsManagerModule to CoreReactPackage Reviewed By: cortinico Differential Revision: D50017783 fbshipit-source-id: 8642bb23bdae50a1e702f5e0586b0ede80007bb1 # Conflicts: # packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterApplication.kt
1 parent 7193bd7 commit 034d815

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

Diff for: packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/CoreReactPackage.java

+5
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import com.facebook.react.module.model.ReactModuleInfoProvider;
2020
import com.facebook.react.modules.core.DefaultHardwareBackBtnHandler;
2121
import com.facebook.react.modules.core.DeviceEventManagerModule;
22+
import com.facebook.react.modules.core.ExceptionsManagerModule;
2223
import com.facebook.react.modules.debug.DevSettingsModule;
2324
import com.facebook.react.modules.debug.SourceCodeModule;
2425
import com.facebook.react.modules.deviceinfo.DeviceInfoModule;
@@ -36,6 +37,7 @@
3637
SourceCodeModule.class,
3738
LogBoxModule.class,
3839
DeviceEventManagerModule.class,
40+
ExceptionsManagerModule.class,
3941
})
4042
class CoreReactPackage extends TurboReactPackage {
4143

@@ -63,6 +65,8 @@ public NativeModule getModule(String name, ReactApplicationContext reactContext)
6365
return new DeviceEventManagerModule(reactContext, mHardwareBackBtnHandler);
6466
case LogBoxModule.NAME:
6567
return new LogBoxModule(reactContext, mDevSupportManager);
68+
case ExceptionsManagerModule.NAME:
69+
return new ExceptionsManagerModule(mDevSupportManager);
6670
default:
6771
throw new IllegalArgumentException(
6872
"In BridgelessReactPackage, could not find Native module for " + name);
@@ -85,6 +89,7 @@ public ReactModuleInfoProvider getReactModuleInfoProvider() {
8589
DevSettingsModule.class,
8690
DeviceEventManagerModule.class,
8791
LogBoxModule.class,
92+
ExceptionsManagerModule.class,
8893
};
8994
final Map<String, ReactModuleInfo> reactModuleInfoMap = new HashMap<>();
9095
for (Class<? extends NativeModule> moduleClass : moduleList) {

Diff for: packages/rn-tester/android/app/src/main/java/com/facebook/react/uiapp/RNTesterApplication.java

-3
Original file line numberDiff line numberDiff line change
@@ -170,9 +170,6 @@ public void onCreate() {
170170

171171
@Override
172172
public ReactNativeHost getReactNativeHost() {
173-
if (ReactFeatureFlags.enableBridgelessArchitecture) {
174-
throw new RuntimeException("Should not use ReactNativeHost when Bridgeless enabled");
175-
}
176173
return mReactNativeHost;
177174
}
178175

0 commit comments

Comments
 (0)