Skip to content

Unfork CallbackWrapper.h and TurboModuleUtils.h #13399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Yajur-Grover opened this issue Jun 27, 2024 · 3 comments
Closed

Unfork CallbackWrapper.h and TurboModuleUtils.h #13399

Yajur-Grover opened this issue Jun 27, 2024 · 3 comments

Comments

@Yajur-Grover
Copy link
Contributor

Summary

During this integration from March 2022, TurboModuleUtils.h and CallbackWrapper.h were forked due to the same path issue in #13391, with the path for TurboModuleUtils.h having two ReactCommon directories. This issue tracks the creation of these forks, as there was no issue created originally.

Motivation

Track as part of integration process for eventual removal

Basic Example

No response

Open Questions

No response

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Jun 27, 2024
@chrisglein chrisglein added this to the Backlog milestone Jun 27, 2024
@chrisglein chrisglein added Deforking and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Jun 27, 2024
@chrisglein
Copy link
Member

Proposed next action: Remove these forks and see what error we get, in order to find out the original reason for the forks.

@Yajur-Grover
Copy link
Contributor Author

Yajur-Grover commented Jun 28, 2024

Tried removing the forks and building playground and got the following results:

Removing both forks:

Error C1083 Cannot open include file: 'react/bridging/CallbackWrapper.h': No such file or directory ReactNativePicker C:\new-account-repos\react-native-windows\node_modules\react-native\ReactCommon\react\nativemodule\core\ReactCommon\CallbackWrapper.h 11

Removing just TurboModuleUtils.h fork:

Error C1083 Cannot open include file: 'react/bridging/CallbackWrapper.h': No such file or directory PlaygroundNativeModules C:\new-account-repos\react-native-windows\node_modules\react-native\ReactCommon\react\nativemodule\core\ReactCommon\CallbackWrapper.h 11
Error C1083 Cannot open include file: 'react/bridging/CallbackWrapper.h': No such file or directory ReactNativePicker C:\new-account-repos\react-native-windows\node_modules\react-native\ReactCommon\react\nativemodule\core\ReactCommon\CallbackWrapper.h 11
Error C1083 Cannot open include file: 'react/bridging/CallbackWrapper.h': No such file or directory playground C:\new-account-repos\react-native-windows\node_modules\react-native\ReactCommon\react\nativemodule\core\ReactCommon\CallbackWrapper.h 11

Removing just CallbackWrapper.h fork:

Error C1083 Cannot open include file: 'react/bridging/LongLivedObject.h': No such file or directory PlaygroundNativeModules C:\new-account-repos\react-native-windows\node_modules\react-native\ReactCommon\react\bridging\CallbackWrapper.h 14
Error C1083 Cannot open include file: 'react/bridging/LongLivedObject.h': No such file or directory ReactNativePicker C:\new-account-repos\react-native-windows\node_modules\react-native\ReactCommon\react\bridging\CallbackWrapper.h 14
Error C1083 Cannot open include file: 'react/bridging/LongLivedObject.h': No such file or directory playground C:\new-account-repos\react-native-windows\node_modules\react-native\ReactCommon\react\bridging\CallbackWrapper.h 14

From these errors, we can assume that the original reason for the forks was due to the path of TurboModuleUtils.h including two ReactCommon directories.

@chiaramooney chiaramooney added the Workstream: Releases and Integrations Keep RNW current with RN releases. label Oct 3, 2024
@Yajur-Grover
Copy link
Contributor Author

Both of these forks were removed in the 10/20 integration: #14092

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants