-
Notifications
You must be signed in to change notification settings - Fork 1.2k
The new app / lib templates should help prevent checking in msbuild binlog files #14160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Related: #5937 |
Changes for this will most likely be in @jonthysell for more help/guidance. |
@jonthysell Looking at helping with this issue.
I suppose we would want to add |
I agree if we just did 2 that would give us what we need and not pollute the project's main folder with build output. It's interesting to me that if you don't specify a folder with I think then, the fix looks something like this in
const binlog = `:${logPrefix}.binlog`; here: react-native-windows/packages/@react-native-windows/cli/src/utils/msbuildtools.ts Lines 104 to 105 in a4e227e
Then we just need to add |
@jonthysell thanks for the guidance! I have a draft PR up, I still want to test it locally better. I was reading the Contributing to the CLI docs, but I didn't quite grok the proper way to test my local CLI changes just yet. |
Summary
init-windows
for the new templates should inject*.binlog
into the project root.gitignore
if the ignore file exists (and the line doesn't exist)Motivation
Right now, if you run
run-windows --logging
you'll get anmsbuild.binlog
file in the root of your project file (where you runrun-windows
99% of the time). This file risks being checked in accidentally.Basic Example
No response
Open Questions
No response
The text was updated successfully, but these errors were encountered: