Skip to content

Remove disableEventLoopOnBridgeless featureflag override #14133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
acoates-ms opened this issue Nov 21, 2024 · 2 comments · May be fixed by #14635
Open

Remove disableEventLoopOnBridgeless featureflag override #14133

acoates-ms opened this issue Nov 21, 2024 · 2 comments · May be fixed by #14635
Labels
enhancement Integration Follow-up Workstream: Releases and Integrations Keep RNW current with RN releases.
Milestone
Next

Comments

@acoates-ms
Copy link
Contributor

As part of this #14092 integration I added an override to the disableEventLoopOnBridgeless featureflag to unblock integrations. But we should ensure that we have the changes needed to enable the eventloop on bridgeless going forward.
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Nov 21, 2024
@chrisglein
Copy link
Member

Feature flags were broken, and that's now fixed. But this functionality which is a big change to how event loops work is disabled (unlike in core where it is on). Turning this on requires an updated version of Hermes and also implementing the microtask stuff in the Windows runtime. Risk of not addressing this soonish is that the old functionality will go away at some point, and also RNW would be running in a different way from core.

@chrisglein chrisglein added this to the Next milestone Dec 2, 2024
@chrisglein chrisglein added enhancement and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Dec 2, 2024
@Yajur-Grover
Copy link
Contributor

So it looks like this override has been made redundant in the current integration, in the following PR: facebook/react-native#48851. This is blocking the current integration until we have an updated version of Hermes available, and have implemented the microtask functionality.

@chrisglein chrisglein added the Workstream: Releases and Integrations Keep RNW current with RN releases. label Jan 29, 2025
@TatianaKapos TatianaKapos mentioned this issue Apr 22, 2025
Draft
@acoates-ms acoates-ms linked a pull request May 2, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Integration Follow-up Workstream: Releases and Integrations Keep RNW current with RN releases.
Projects
None yet
Milestone
Next
Development

Successfully merging a pull request may close this issue.

Bump hermes version - enable hermes native microtasks acoates-ms/react-native-windows
3 participants
@chrisglein @acoates-ms @Yajur-Grover