Merge pull request #82 from Microsoft/alebet/fixSeedReducers

abettadapur · web-flow · commit 89ee2c172eec · 2019-05-02T13:07:11.000-07:00
Seed all reducers at once
diff --git a/packages/redux-dynamic-modules-core/src/Managers/ModuleManager.ts b/packages/redux-dynamic-modules-core/src/Managers/ModuleManager.ts
@@ -73,9 +73,6 @@ export function getModuleManager<State>(
                 _reducerManager.add(key, reducerMap[key]);
             }
         }
-
-        /* Fire an action so that the newly added reducers can seed their initial state */
-        _seedReducers();
     };
 
     const _removeReducers = (
@@ -122,6 +119,9 @@ export function getModuleManager<State>(
                 }
             });
 
+            /* Fire an action so that the newly added reducers can seed their initial state */
+            _seedReducers();
+
             // add the sagas and dispatch actions at the end so all the reducers are registered
             justAddedModules.forEach(module => {
                 // Let the extensions know we added a module

Original file line number	Diff line number	Diff line change
`@@ -73,9 +73,6 @@ export function getModuleManager<State>(`
`73`	`73`	`_reducerManager.add(key, reducerMap[key]);`
`74`	`74`	`}`
`75`	`75`	`}`
`76`		`-`
`77`		`- /* Fire an action so that the newly added reducers can seed their initial state */`
`78`		`- _seedReducers();`
`79`	`76`	`};`
`80`	`77`
`81`	`78`	`const _removeReducers = (`
`@@ -122,6 +119,9 @@ export function getModuleManager<State>(`
`122`	`119`	`}`
`123`	`120`	`});`
`124`	`121`
	`122`	`+ /* Fire an action so that the newly added reducers can seed their initial state */`
	`123`	`+ _seedReducers();`
	`124`	`+`
`125`	`125`	`// add the sagas and dispatch actions at the end so all the reducers are registered`
`126`	`126`	`justAddedModules.forEach(module => {`
`127`	`127`	`// Let the extensions know we added a module`