Convert "firstExportingConsumableParent" property to "getFirstExportingConsumableParent()" method because it does nontrivial work

octogonz · octogonz · commit 6d975b572875 · 2022-09-12T15:56:43.000-07:00
diff --git a/apps/api-extractor/src/collector/CollectorEntity.ts b/apps/api-extractor/src/collector/CollectorEntity.ts
@@ -179,7 +179,7 @@ export class CollectorEntity {
    * Return the first consumable parent that exports this entity. If there is none, returns
    * `undefined`.
    */
-  public get firstExportingConsumableParent(): CollectorEntity | undefined {
+  public getFirstExportingConsumableParent(): CollectorEntity | undefined {
     for (const [parent, localExportNames] of this._localExportNamesByParent) {
       if (parent.consumable && localExportNames.size > 0) {
         return parent;
diff --git a/apps/api-extractor/src/generators/DeclarationReferenceGenerator.ts b/apps/api-extractor/src/generators/DeclarationReferenceGenerator.ts
@@ -284,7 +284,7 @@ export class DeclarationReferenceGenerator {
       }
 
       const firstExportingConsumableParent: CollectorEntity | undefined =
-        entity.firstExportingConsumableParent;
+        entity.getFirstExportingConsumableParent();
       if (
         firstExportingConsumableParent &&
         firstExportingConsumableParent.astEntity instanceof AstNamespaceImport

Original file line number	Diff line number	Diff line change
`@@ -284,7 +284,7 @@ export class DeclarationReferenceGenerator {`
`284`	`284`	`}`
`285`	`285`
`286`	`286`	`const firstExportingConsumableParent: CollectorEntity \| undefined =`
`287`		`- entity.firstExportingConsumableParent;`
	`287`	`+ entity.getFirstExportingConsumableParent();`
`288`	`288`	`if (`
`289`	`289`	`firstExportingConsumableParent &&`
`290`	`290`	`firstExportingConsumableParent.astEntity instanceof AstNamespaceImport`