Merge pull request #3621 from iclanton/user/ianc/duplicate-resx-string-test

[localization utilities] Add a test for a RESX file with a duplicate entry.

Author: iclanton

common/changes/@rushstack/localization-utilities/user-ianc-duplicate-resx-string-test_2022-09-10-22-49.json

@@ -0,0 +1,11 @@
+{
+  "changes": [
+    {
+      "comment": "",
+      "type": "none",
+      "packageName": "@rushstack/localization-utilities"
+    }
+  ],
+  "packageName": "@rushstack/localization-utilities",
+  "email": "[email protected]"
+}

libraries/localization-utilities/src/parsers/test/__snapshots__/parseResx.test.ts.snap

@@ -24,6 +24,21 @@ Array [
 
 exports[`parseResx correctly ignores a string: terminal output 1`] = `Object {}`;
 
+exports[`parseResx fails to parse a RESX file with a duplicate string: Loc file 1`] = `
+Object {
+  "stringA": Object {
+    "comment": undefined,
+    "value": "Another string",
+  },
+}
+`;
+
+exports[`parseResx fails to parse a RESX file with a duplicate string: terminal output 1`] = `
+Object {
+  "errorOutput": "test.resx(6,45): Duplicate string value \\"stringA\\"[n]",
+}
+`;
+
 exports[`parseResx ignoreMissingResxComments when set to false, warns on a missing comment: Loc file 1`] = `
 Object {
   "stringWithoutAComment": Object {

libraries/localization-utilities/src/parsers/test/parseResx.test.ts

@@ -56,7 +56,8 @@ describe(parseResx.name, () => {
       | 'resxWithSchema'
       | 'stringWithoutComment'
       | 'stringWithQuotemarks'
-      | 'withNewlines',
+      | 'withNewlines'
+      | 'resxWithDuplicateEntry',
     optionsOverride: Partial<IParseResxOptions> = {}
   ): Promise<void> {
     const content: string = await FileSystem.readFileAsync(`${__dirname}/testResxFiles/${filename}.resx`);
@@ -134,4 +135,8 @@ describe(parseResx.name, () => {
       });
     });
   });
+
+  it('fails to parse a RESX file with a duplicate string', async () => {
+    await testResxAsync('resxWithDuplicateEntry');
+  });
 });

libraries/localization-utilities/src/parsers/test/testResxFiles/resxWithDuplicateEntry.resx

@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<root>
+  <data name="stringA" xml:space="preserve">
+    <value>A string</value>
+  </data>
+  <data name="stringA" xml:space="preserve">
+    <value>Another string</value>
+  </data>
+</root>