Small bug fix

Author: zelliott

apps/api-extractor/src/enhancers/ValidationEnhancer.ts

@@ -210,9 +210,8 @@ export class ValidationEnhancer {
           continue;
         }
 
-        localName = rootSymbol.localName;
-
         collectorEntity = collector.tryGetCollectorEntity(rootSymbol);
+        localName = collectorEntity?.nameForEmit || rootSymbol.localName;
 
         const referencedMetadata: SymbolMetadata = collector.fetchSymbolMetadata(referencedEntity);
         referencedReleaseTag = referencedMetadata.maxEffectiveReleaseTag;
@@ -222,7 +221,7 @@ export class ValidationEnhancer {
         // TODO: Currently the "import * as ___ from ___" syntax does not yet support doc comments
         referencedReleaseTag = ReleaseTag.Public;
 
-        localName = referencedEntity.localName;
+        localName = collectorEntity?.nameForEmit || referencedEntity.localName;
       } else {
         continue;
       }
@@ -233,7 +232,7 @@ export class ValidationEnhancer {
             ExtractorMessageId.IncompatibleReleaseTags,
             `The symbol "${astDeclaration.astSymbol.localName}"` +
               ` is marked as ${ReleaseTag.getTagName(declarationReleaseTag)},` +
-              ` but its signature references "${referencedEntity.localName}"` +
+              ` but its signature references "${localName}"` +
               ` which is marked as ${ReleaseTag.getTagName(referencedReleaseTag)}`,
             astDeclaration
           );

build-tests/api-extractor-scenarios/etc/ambientNameConflict/api-extractor-scenarios.api.md

@@ -4,7 +4,7 @@
 
 ```ts
 
-// Warning: (ae-forgotten-export) The symbol "Promise" needs to be exported by the entry point index.d.ts
+// Warning: (ae-forgotten-export) The symbol "Promise_2" needs to be exported by the entry point index.d.ts
 //
 // @public (undocumented)
 export function ambientNameConflict(p1: Promise<void>, p2: Promise_2<void>): void;

build-tests/api-extractor-scenarios/etc/includeForgottenExports/api-extractor-scenarios.api.md

@@ -9,7 +9,7 @@
 // (undocumented)
 type AnotherForgottenExport = number;
 
-// Warning: (ae-forgotten-export) The symbol "DuplicateName" needs to be exported by the entry point index.d.ts
+// Warning: (ae-forgotten-export) The symbol "DuplicateName_2" needs to be exported by the entry point index.d.ts
 //
 // @public (undocumented)
 export function anotherFunction(): DuplicateName_2;

build-tests/api-extractor-test-01/etc/api-extractor-test-01.api.md

@@ -110,7 +110,7 @@ export class ForgottenExportConsumer1 {
 
 // @public (undocumented)
 export class ForgottenExportConsumer2 {
-    // Warning: (ae-forgotten-export) The symbol "IForgottenExport" needs to be exported by the entry point index.d.ts
+    // Warning: (ae-forgotten-export) The symbol "IForgottenExport_2" needs to be exported by the entry point index.d.ts
     //
     // (undocumented)
     test2(): IForgottenExport_2 | undefined;
@@ -203,5 +203,4 @@ export const VARIABLE: string;
 // @public
 export function virtual(target: Object, propertyKey: string | symbol, descriptor: TypedPropertyDescriptor<any>): void;
 
-
 ```