.Net: Fix PlatformNotSupportedException from HttpClientProvider (#6323)

stephentoub · web-flow · commit 915662ce8550 · 2024-05-18T20:33:57.000Z
On older .NET Frameworks, CheckCertificateRevocationList may not be supported. https://learn.microsoft.com/en-us/dotnet/api/system.net.http.httpclienthandler.checkcertificaterevocationlist?view=net-8.0#exceptions
diff --git a/dotnet/src/InternalUtilities/src/Http/HttpClientProvider.cs b/dotnet/src/InternalUtilities/src/Http/HttpClientProvider.cs
@@ -91,11 +91,13 @@ private static SocketsHttpHandler CreateHandler()
 #else
         private static HttpClientHandler CreateHandler()
         {
-            return new HttpClientHandler()
+            var handler = new HttpClientHandler();
+            try
             {
-                // Check cert revocation
-                CheckCertificateRevocationList = true,
-            };
+                handler.CheckCertificateRevocationList = true;
+            }
+            catch (PlatformNotSupportedException) { } // not supported on older frameworks
+            return handler;
         }
 #endif
     }

Original file line number	Diff line number	Diff line change
`@@ -91,11 +91,13 @@ private static SocketsHttpHandler CreateHandler()`
`91`	`91`	`#else`
`92`	`92`	`private static HttpClientHandler CreateHandler()`
`93`	`93`	`{`
`94`		`- return new HttpClientHandler()`
	`94`	`+ var handler = new HttpClientHandler();`
	`95`	`+ try`
`95`	`96`	`{`
`96`		`- // Check cert revocation`
`97`		`- CheckCertificateRevocationList = true,`
`98`		`- };`
	`97`	`+ handler.CheckCertificateRevocationList = true;`
	`98`	`+ }`
	`99`	`+ catch (PlatformNotSupportedException) { } // not supported on older frameworks`
	`100`	`+ return handler;`
`99`	`101`	`}`
`100`	`102`	`#endif`
`101`	`103`	`}`