Skip to content

Commit 9c71640

Browse files
authored
.Net: Changes to support .NET9 formatting (#10838)
### Motivation and Context In sdk9, there is a bug fix to one of the analyzers: [https://github.com/dotnet/msbuild/issues/11426](https://github.com/dotnet/msbuild/issues/11426). This causes the code base to fail in the `dotnet format` stage when built on sdk9. This PR fixes the file that has been changed this week and adds a configuration into the build to format using sdk9.0 so that the build fails if more are introduced. - [x] The code builds clean without any errors or warnings - [ ] The PR follows the [SK Contribution Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄 This relates to #10716 and was previously fixed in #10741
1 parent 24109aa commit 9c71640

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

.github/workflows/dotnet-format.yml

+1
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ jobs:
2626
matrix:
2727
include:
2828
- { dotnet: "8.0", configuration: Release, os: ubuntu-latest }
29+
- { dotnet: "9.0", configuration: Release, os: ubuntu-latest }
2930

3031
runs-on: ${{ matrix.os }}
3132
env:

dotnet/src/Experimental/Process.Abstractions/IKernelExternalProcessMessageChannel.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,5 +28,5 @@ public interface IExternalKernelProcessMessageChannel
2828
/// <param name="externalTopicEvent">name of the topic to be used externally as the event name</param>
2929
/// <param name="eventData">data to be transmitted externally</param>
3030
/// <returns></returns>
31-
public abstract Task EmitExternalEventAsync(string externalTopicEvent, KernelProcessProxyMessage eventData);
31+
abstract Task EmitExternalEventAsync(string externalTopicEvent, KernelProcessProxyMessage eventData);
3232
}

0 commit comments

Comments
 (0)