address feedback

carlos-zamora · carlos-zamora · commit 7cdbb7c795c9 · 2025-02-27T10:17:11.000-08:00
diff --git a/src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp b/src/cascadia/TerminalSettingsModel/GlobalAppSettings.cpp
@@ -94,7 +94,11 @@ winrt::com_ptr<GlobalAppSettings> GlobalAppSettings::Copy() const
     }
     if (_DisabledProfileSources)
     {
-        globals->_DisabledProfileSources = winrt::single_threaded_vector<hstring>(std::move(wil::to_vector(*globals->_DisabledProfileSources)));
+        globals->_DisabledProfileSources = winrt::single_threaded_vector<hstring>();
+        for (const auto& src : *_DisabledProfileSources)
+        {
+            globals->_DisabledProfileSources->Append(src);
+        }
     }
 
     for (const auto& parent : _parents)

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,11 @@ winrt::com_ptr<GlobalAppSettings> GlobalAppSettings::Copy() const`
`94`	`94`	`}`
`95`	`95`	`if (_DisabledProfileSources)`
`96`	`96`	`{`
`97`		`- globals->_DisabledProfileSources = winrt::single_threaded_vector<hstring>(std::move(wil::to_vector(*globals->_DisabledProfileSources)));`
	`97`	`+ globals->_DisabledProfileSources = winrt::single_threaded_vector<hstring>();`
	`98`	`+ for (const auto& src : *_DisabledProfileSources)`
	`99`	`+ {`
	`100`	`+ globals->_DisabledProfileSources->Append(src);`
	`101`	`+ }`
`98`	`102`	`}`
`99`	`103`
`100`	`104`	`for (const auto& parent : _parents)`