Skip to content

Provide best-effort links to contents in node_modules #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DanielRosenwasser opened this issue Nov 8, 2024 · 0 comments
Open

Provide best-effort links to contents in node_modules #171

DanielRosenwasser opened this issue Nov 8, 2024 · 0 comments

Comments

@DanielRosenwasser
Copy link
Member

In cases where an error is reported from a file in node_modules, we end up with output like the following:

packages/utils/devEnv/tsconfig.json

  • error TS2694: Namespace '"/mnt/ts_downloads/_/m/theatre/node_modules/@types/estree/index"' has no exported member 'StaticBlock'.
    • file:///mnt/ts_downloads/_/m/theatre/node_modules/@types/eslint/index.d.ts#L617
    • file:///mnt/ts_downloads/_/m/theatre/node_modules/@types/eslint/index.d.ts#L618
  • error TS2300: Duplicate identifier 'ElementType'.
    • file:///mnt/ts_downloads/_/m/theatre/node_modules/@types/hoist-non-react-statics/node_modules/@types/react/index.d.ts#L3244
    • file:///mnt/ts_downloads/_/m/theatre/node_modules/@types/react/index.d.ts#L3244
  • error TS2300: Duplicate identifier 'LibraryManagedAttributes'.
    • file:///mnt/ts_downloads/_/m/theatre/node_modules/@types/hoist-non-react-statics/node_modules/@types/react/index.d.ts#L3254

I think it would be helpful if we could provide a link to the exact version on unpkg, or more ideally, GitHub if we could really figure that out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant