Skip to content

[Feature] Don't report OOMs unless they're new #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amcasey opened this issue Oct 19, 2022 · 1 comment
Closed

[Feature] Don't report OOMs unless they're new #86

amcasey opened this issue Oct 19, 2022 · 1 comment

Comments

@amcasey
Copy link
Member

amcasey commented Oct 19, 2022

If both the candidate and baseline versions of tsserver crash with OOM (usually SIGABRT or code 134), don't bother to include that failure in the public report.
@amcasey
Copy link
Member Author

amcasey commented Oct 19, 2022

Actually, a better approach would be to add affected repos to the exclusion list.

@amcasey amcasey closed this as completed Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@amcasey