No tree view with id 'github:compareChanges' registered. (#3555)

alexr00 · web-flow · commit e23ca3d5d14b · 2022-05-12T08:25:04.000-07:00
Fixes #3549
diff --git a/src/view/compareChangesTreeDataProvider.ts b/src/view/compareChangesTreeDataProvider.ts
@@ -144,6 +144,8 @@ export class CompareChangesTreeProvider implements vscode.TreeDataProvider<TreeN
 
 			if (!data.files.length) {
 				this._view.message = `There are no commits between the base '${this.baseBranchName}' branch and the comparing '${this.compareBranchName}' branch`;
+			} else if (this._isDisposed) {
+				return [];
 			} else {
 				this._view.message = undefined;
 			}
@@ -164,7 +166,9 @@ export class CompareChangesTreeProvider implements vscode.TreeDataProvider<TreeN
 		}
 	}
 
+	private _isDisposed: boolean = false;
 	dispose() {
+		this._isDisposed = true;
 		this._disposables.forEach(d => d.dispose());
 		this._contentProvider = undefined;
 	}

Original file line number	Diff line number	Diff line change
`@@ -144,6 +144,8 @@ export class CompareChangesTreeProvider implements vscode.TreeDataProvider<TreeN`
`144`	`144`
`145`	`145`	`if (!data.files.length) {`
`146`	`146`	this._view.message = `There are no commits between the base '${this.baseBranchName}' branch and the comparing '${this.compareBranchName}' branch`;
	`147`	`+ } else if (this._isDisposed) {`
	`148`	`+ return [];`
`147`	`149`	`} else {`
`148`	`150`	`this._view.message = undefined;`
`149`	`151`	`}`
`@@ -164,7 +166,9 @@ export class CompareChangesTreeProvider implements vscode.TreeDataProvider<TreeN`
`164`	`166`	`}`
`165`	`167`	`}`
`166`	`168`
	`169`	`+ private _isDisposed: boolean = false;`
`167`	`170`	`dispose() {`
	`171`	`+ this._isDisposed = true;`
`168`	`172`	`this._disposables.forEach(d => d.dispose());`
`169`	`173`	`this._contentProvider = undefined;`
`170`	`174`	`}`