Skip to content

Commit 2a26835

Browse files
authored
Drop prompt displayed on first extension launch (#15648)
* Drop prompt displayed on first extension launch * Remove files from .eslintignore
1 parent 64a2039 commit 2a26835

File tree

7 files changed

+1
-184
lines changed

7 files changed

+1
-184
lines changed

.eslintignore

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ src/test/interpreters/pythonPathUpdaterFactory.unit.test.ts
5454
src/test/interpreters/activation/service.unit.test.ts
5555
src/test/interpreters/helpers.unit.test.ts
5656
src/test/interpreters/currentPathService.unit.test.ts
57-
src/test/interpreters/display/interpreterSelectionTip.unit.test.ts
5857
src/test/interpreters/display.unit.test.ts
5958

6059
src/test/configuration/interpreterSelector/interpreterSelector.unit.test.ts
@@ -313,7 +312,6 @@ src/client/interpreter/autoSelection/rules/system.ts
313312
src/client/interpreter/activation/service.ts
314313
src/client/interpreter/display/shebangCodeLensProvider.ts
315314
src/client/interpreter/display/index.ts
316-
src/client/interpreter/display/interpreterSelectionTip.ts
317315

318316
src/client/api.ts
319317
src/client/extension.ts

news/1 Enhancements/15647.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Drop prompt being displayed on first extension launch with a tip or a survey.

src/client/common/experiments/groups.ts

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,6 @@ export enum TryPylance {
2525
jediPrompt2 = 'tryPylancePromptText2',
2626
}
2727

28-
// Experiment for the content of the tip being displayed on first extension launch:
29-
// interpreter selection tip, feedback survey or nothing.
30-
export enum SurveyAndInterpreterTipNotification {
31-
tipExperiment = 'pythonTipPromptWording',
32-
surveyExperiment = 'pythonMailingListPromptWording',
33-
}
34-
3528
// Experiment to switch Jedi to use an LSP instead of direct providers
3629
export enum JediLSP {
3730
experiment = 'pythonJediLSP',

src/client/interpreter/display/interpreterSelectionTip.ts

Lines changed: 0 additions & 83 deletions
This file was deleted.

src/client/interpreter/serviceRegistry.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ import {
4848
IShebangCodeLensProvider,
4949
} from './contracts';
5050
import { InterpreterDisplay } from './display';
51-
import { InterpreterSelectionTip } from './display/interpreterSelectionTip';
5251
import { InterpreterLocatorProgressStatubarHandler } from './display/progressDisplay';
5352
import { ShebangCodeLensProvider } from './display/shebangCodeLensProvider';
5453
import { InterpreterHelper } from './helpers';
@@ -86,10 +85,6 @@ export function registerInterpreterTypes(serviceManager: IServiceManager): void
8685
serviceManager.addSingleton<IInterpreterSecurityService>(IInterpreterSecurityService, InterpreterSecurityService);
8786

8887
serviceManager.addSingleton<IExtensionActivationService>(IExtensionActivationService, VirtualEnvironmentPrompt);
89-
serviceManager.addSingleton<IExtensionSingleActivationService>(
90-
IExtensionSingleActivationService,
91-
InterpreterSelectionTip,
92-
);
9388

9489
serviceManager.addSingleton<IInterpreterVersionService>(IInterpreterVersionService, InterpreterVersionService);
9590

src/test/interpreters/display/interpreterSelectionTip.unit.test.ts

Lines changed: 0 additions & 85 deletions
This file was deleted.

src/test/interpreters/serviceRegistry.unit.test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ import {
4848
IShebangCodeLensProvider,
4949
} from '../../client/interpreter/contracts';
5050
import { InterpreterDisplay } from '../../client/interpreter/display';
51-
import { InterpreterSelectionTip } from '../../client/interpreter/display/interpreterSelectionTip';
5251
import { InterpreterLocatorProgressStatubarHandler } from '../../client/interpreter/display/progressDisplay';
5352
import { ShebangCodeLensProvider } from '../../client/interpreter/display/shebangCodeLensProvider';
5453
import { InterpreterHelper } from '../../client/interpreter/helpers';
@@ -74,7 +73,6 @@ suite('Interpreters - Service Registry', () => {
7473
[IInterpreterSecurityService, InterpreterSecurityService],
7574

7675
[IExtensionActivationService, VirtualEnvironmentPrompt],
77-
[IExtensionSingleActivationService, InterpreterSelectionTip],
7876

7977
[IInterpreterVersionService, InterpreterVersionService],
8078

0 commit comments

Comments
 (0)