Some more comments

Author: Kartik Raj

src/client/pythonEnvironments/common/environmentIdentifier.ts

@@ -182,20 +182,30 @@ function isLocalPipenvEnvironment(interpreterPath: string): boolean {
  * Returns true if interpreter path belongs to a global pipenv environment created for a particular project,
  * false otherwise.
  * @param interpreterPath Absolute path to any python interpreter.
- * @param cwd Absolute path to the project.
+ * @param project Absolute path to the project.
  */
-async function isGlobalPipenvEnvironmentRelatedToProject(interpreterPath: string, cwd: string): Promise<boolean> {
+async function isGlobalPipenvEnvironmentRelatedToProject(interpreterPath: string, project: string): Promise<boolean> {
     // PIPENV_NO_INHERIT is used to tell pipenv not to look for Pipfile in parent directories
     // https://pipenv.pypa.io/en/latest/advanced/#pipenv.environments.PIPENV_NO_INHERIT
-    if (!checkIfPipFileExists(cwd, !process.env.PIPENV_NO_INHERIT)) {
+    if (!checkIfPipFileExists(project, !process.env.PIPENV_NO_INHERIT)) {
         return false;
     }
 
-    // In PipEnv, for global environments the name of the cwd is used as a prefix in the virtual env.
-    if (interpreterPath.indexOf(`${path.sep}${path.basename(cwd)}-`) === -1) {
-        return false;
+    /**
+     * Global pipenv environments can be stored in 3 possible locations:
+     * * WORKON_HOME environment variable: https://pipenv-fork.readthedocs.io/en/latest/advanced.html#custom-virtual-environment-location
+     * * ~/.virtualenvs - for windows
+     * * ~/.local/share/virtualenvs
+     *
+     * The name of the project is used as a prefix in the virtual env. We're assuming it's unique enough
+     * detail so we don't have further ensure that the environment exists within these locations.
+     */
+    if (interpreterPath.indexOf(`${path.sep}${path.basename(project)}-`) !== -1) {
+        // Note it's still possible that this virtual environment belongs to another project with the same name,
+        // and not this project. But the type of environment would still be pipenv, so we need not care.
+        return true;
     }
-    return true;
+    return false;
 }
 
 /**