Update changelog and version for point release. (#13610)

* Show the server display string that the user is going to connect to after selecting a compute instance and reloading the window. (#13600)

* Update "Tip" notification for new users to either show the existing tip, a link to a feedback survey or nothing (#13554)

* Update vscode-tas-client
* Add experiment group enum
* Add method to retrieve experiment values
* Implementation + tests
* News file
* Update wording of the news entry
* Add telemetry
* More tests
* No opting-in and out of this one
* Don't fetch value if opted out, add tests
* Address comments

* Fix save on close (#13567)

* Pass model through command instead of URI in order to use directly

* Add a test to verify we don't regress

* Finish fixing tests

* Add news entry

* Fix unit tests

* Update changelog and version for point release.

* Change date.

* Format using latest black (#13625)

Co-authored-by: Shantnu Suman <[email protected]>
Co-authored-by: Kim-Adeline Miguel <[email protected]>
Co-authored-by: Rich Chiodo <[email protected]>

Author: 4 people

CHANGELOG.md

@@ -1,5 +1,73 @@
 # Changelog
 
+## 2020.8.2 (27 August 2020)
+
+### Enhancements
+
+1. Update "Tip" notification for new users to either show the existing tip, a link to a feedback survey or nothing.
+   ([#13535](https://github.com/Microsoft/vscode-python/issues/13535))
+
+### Fixes
+
+1. Fix saving during close and auto backup to actually save a notebook.
+   ([#11711](https://github.com/Microsoft/vscode-python/issues/11711))
+1. Show the server display string that the user is going to connect to after selecting a compute instance and reloading the window.
+   ([#13551](https://github.com/Microsoft/vscode-python/issues/13551))
+
+### Thanks
+
+Thanks to the following projects which we fully rely on to provide some of
+our features:
+
+-   [debugpy](https://pypi.org/project/debugpy/)
+-   [isort](https://pypi.org/project/isort/)
+-   [jedi](https://pypi.org/project/jedi/)
+    and [parso](https://pypi.org/project/parso/)
+-   [Microsoft Python Language Server](https://github.com/microsoft/python-language-server)
+-   [Pylance](https://github.com/microsoft/pylance-release)
+-   [exuberant ctags](http://ctags.sourceforge.net/) (user-installed)
+-   [rope](https://pypi.org/project/rope/) (user-installed)
+
+Also thanks to the various projects we provide integrations with which help
+make this extension useful:
+
+-   Debugging support:
+    [Django](https://pypi.org/project/Django/),
+    [Flask](https://pypi.org/project/Flask/),
+    [gevent](https://pypi.org/project/gevent/),
+    [Jinja](https://pypi.org/project/Jinja/),
+    [Pyramid](https://pypi.org/project/pyramid/),
+    [PySpark](https://pypi.org/project/pyspark/),
+    [Scrapy](https://pypi.org/project/Scrapy/),
+    [Watson](https://pypi.org/project/Watson/)
+-   Formatting:
+    [autopep8](https://pypi.org/project/autopep8/),
+    [black](https://pypi.org/project/black/),
+    [yapf](https://pypi.org/project/yapf/)
+-   Interpreter support:
+    [conda](https://conda.io/),
+    [direnv](https://direnv.net/),
+    [pipenv](https://pypi.org/project/pipenv/),
+    [pyenv](https://github.com/pyenv/pyenv),
+    [venv](https://docs.python.org/3/library/venv.html#module-venv),
+    [virtualenv](https://pypi.org/project/virtualenv/)
+-   Linting:
+    [bandit](https://pypi.org/project/bandit/),
+    [flake8](https://pypi.org/project/flake8/),
+    [mypy](https://pypi.org/project/mypy/),
+    [prospector](https://pypi.org/project/prospector/),
+    [pylint](https://pypi.org/project/pylint/),
+    [pydocstyle](https://pypi.org/project/pydocstyle/),
+    [pylama](https://pypi.org/project/pylama/)
+-   Testing:
+    [nose](https://pypi.org/project/nose/),
+    [pytest](https://pypi.org/project/pytest/),
+    [unittest](https://docs.python.org/3/library/unittest.html#module-unittest)
+
+And finally thanks to the [Python](https://www.python.org/) development team and
+community for creating a fantastic programming language and community to be a
+part of!
+
 ## 2020.8.1 (20 August 2020)
 
 ### Fixes

package-lock.json

@@ -2,7 +2,7 @@
     "name": "python",
     "displayName": "Python",
     "description": "Linting, Debugging (multi-threaded, remote), Intellisense, Jupyter Notebooks, code formatting, refactoring, unit tests, snippets, and more.",
-    "version": "2020.8.1",
+    "version": "2020.8.2",
     "featureFlags": {
         "usingNewInterpreterStorage": true
     },
@@ -3527,7 +3527,7 @@
         "vscode-languageclient": "^7.0.0-next.8",
         "vscode-languageserver": "^7.0.0-next.6",
         "vscode-languageserver-protocol": "^3.16.0-next.6",
-        "vscode-tas-client": "^0.0.864",
+        "vscode-tas-client": "^0.1.4",
         "vsls": "^0.3.1291",
         "winreg": "^1.2.4",
         "winston": "^3.2.1",

package.json

@@ -86,8 +86,7 @@ def _get_top_level_module(cls, path):
         return path
 
     def _generate_signature(self, completion):
-        """Generate signature with function arguments.
-        """
+        """Generate signature with function arguments."""
         if completion.type in ["module"] or not hasattr(completion, "params"):
             return ""
         return "%s(%s)" % (
@@ -551,8 +550,8 @@ def _set_request_config(self, config):
 
     def _normalize_request_path(self, request):
         """Normalize any Windows paths received by a *nix build of
-           Python. Does not alter the reverse os.path.sep=='\\',
-           i.e. *nix paths received by a Windows build of Python.
+        Python. Does not alter the reverse os.path.sep=='\\',
+        i.e. *nix paths received by a Windows build of Python.
         """
         if "path" in request:
             if not self.drive_mount:
@@ -569,8 +568,7 @@ def _normalize_request_path(self, request):
                 request["path"] = newPath
 
     def _process_request(self, request):
-        """Accept serialized request from VSCode and write response.
-        """
+        """Accept serialized request from VSCode and write response."""
         request = self._deserialize(request)
 
         self._set_request_config(request.get("config", {}))

pythonFiles/completion.py

@@ -52,8 +52,7 @@ class ChangeType:
 
 
 class Change:
-    """
-    """
+    """"""
 
     EDIT = 0
     NEW = 1
@@ -337,8 +336,7 @@ def _deserialize(self, request):
         return json.loads(request)
 
     def _process_request(self, request):
-        """Accept serialized request from VSCode and write response.
-        """
+        """Accept serialized request from VSCode and write response."""
         request = self._deserialize(request)
         lookup = request.get("lookup", "")
 

pythonFiles/refactor.py

@@ -19,7 +19,8 @@ def _check_binaries(dir_path):
 
 
 @pytest.mark.skipif(
-    sys.version_info[:2] != (3, 7), reason="DEBUGPY wheels shipped for Python 3.7 only",
+    sys.version_info[:2] != (3, 7),
+    reason="DEBUGPY wheels shipped for Python 3.7 only",
 )
 def test_install_debugpy(tmpdir):
     import install_debugpy

pythonFiles/tests/debug_adapter/test_install_debugpy.py

@@ -35,7 +35,10 @@ def test_discover(self):
         add_subparser("discover", "pytest", subparsers)
 
         self.assertEqual(
-            stub.calls, [("subparsers.add_parser", None, {"name": "pytest"}),]
+            stub.calls,
+            [
+                ("subparsers.add_parser", None, {"name": "pytest"}),
+            ],
         )
 
     def test_unsupported_command(self):

pythonFiles/tests/testing_tools/adapter/pytest/test_cli.py

@@ -185,11 +185,21 @@ def normcase(path):
         raise NotImplementedError
     ##########
     def _fix_fileid(*args):
-        return fix_fileid(*args, **dict(_normcase=normcase, _pathsep=pathsep,))
+        return fix_fileid(
+            *args,
+            **dict(
+                _normcase=normcase,
+                _pathsep=pathsep,
+            )
+        )
 
     def _normalize_test_id(*args):
         return pytest_item._normalize_test_id(
-            *args, **dict(_fix_fileid=_fix_fileid, _pathsep=pathsep,)
+            *args,
+            **dict(
+                _fix_fileid=_fix_fileid,
+                _pathsep=pathsep,
+            )
         )
 
     def _iter_nodes(*args):
@@ -203,20 +213,39 @@ def _iter_nodes(*args):
         )
 
     def _parse_node_id(*args):
-        return pytest_item._parse_node_id(*args, **dict(_iter_nodes=_iter_nodes,))
+        return pytest_item._parse_node_id(
+            *args,
+            **dict(
+                _iter_nodes=_iter_nodes,
+            )
+        )
 
     ##########
     def _split_fspath(*args):
-        return pytest_item._split_fspath(*args, **dict(_normcase=normcase,))
+        return pytest_item._split_fspath(
+            *args,
+            **dict(
+                _normcase=normcase,
+            )
+        )
 
     ##########
     def _matches_relfile(*args):
         return pytest_item._matches_relfile(
-            *args, **dict(_normcase=normcase, _pathsep=pathsep,)
+            *args,
+            **dict(
+                _normcase=normcase,
+                _pathsep=pathsep,
+            )
         )
 
     def _is_legacy_wrapper(*args):
-        return pytest_item._is_legacy_wrapper(*args, **dict(_pathsep=pathsep,))
+        return pytest_item._is_legacy_wrapper(
+            *args,
+            **dict(
+                _pathsep=pathsep,
+            )
+        )
 
     def _get_location(*args):
         return pytest_item._get_location(
@@ -286,7 +315,9 @@ def test_failure(self):
 
         self.assertEqual(
             stub.calls,
-            [("pytest.main", None, {"args": self.DEFAULT_ARGS, "plugins": [plugin]}),],
+            [
+                ("pytest.main", None, {"args": self.DEFAULT_ARGS, "plugins": [plugin]}),
+            ],
         )
 
     def test_no_tests_found(self):
@@ -778,7 +809,9 @@ def test_doctest(self):
                             id="./x/y/z/test_eggs.py::test_eggs",
                             name="test_eggs",
                             path=TestPath(
-                                root=testroot, relfile=fix_relpath(relfile), func=None,
+                                root=testroot,
+                                relfile=fix_relpath(relfile),
+                                func=None,
                             ),
                             source="{}:{}".format(fix_relpath(relfile), 1),
                             markers=[],
@@ -801,7 +834,9 @@ def test_doctest(self):
                             id="./x/y/z/test_eggs.py::test_eggs.TestSpam",
                             name="test_eggs.TestSpam",
                             path=TestPath(
-                                root=testroot, relfile=fix_relpath(relfile), func=None,
+                                root=testroot,
+                                relfile=fix_relpath(relfile),
+                                func=None,
                             ),
                             source="{}:{}".format(fix_relpath(relfile), 13),
                             markers=[],
@@ -824,7 +859,9 @@ def test_doctest(self):
                             id="./x/y/z/test_eggs.py::test_eggs.TestSpam.TestEggs",
                             name="test_eggs.TestSpam.TestEggs",
                             path=TestPath(
-                                root=testroot, relfile=fix_relpath(relfile), func=None,
+                                root=testroot,
+                                relfile=fix_relpath(relfile),
+                                func=None,
                             ),
                             source="{}:{}".format(fix_relpath(relfile), 28),
                             markers=[],

pythonFiles/tests/testing_tools/adapter/pytest/test_discovery.py

@@ -48,7 +48,12 @@ def test_unsupported_command(self):
 
 class ParseDiscoverTests(unittest.TestCase):
     def test_pytest_default(self):
-        tool, cmd, args, toolargs = parse_args(["discover", "pytest",])
+        tool, cmd, args, toolargs = parse_args(
+            [
+                "discover",
+                "pytest",
+            ]
+        )
 
         self.assertEqual(tool, "pytest")
         self.assertEqual(cmd, "discover")
@@ -88,7 +93,13 @@ def test_pytest_full(self):
 
     def test_pytest_opts(self):
         tool, cmd, args, toolargs = parse_args(
-            ["discover", "pytest", "--simple", "--no-hide-stdio", "--pretty",]
+            [
+                "discover",
+                "pytest",
+                "--simple",
+                "--no-hide-stdio",
+                "--pretty",
+            ]
         )
 
         self.assertEqual(tool, "pytest")
@@ -120,8 +131,14 @@ def test_discover(self):
             "discover",
             {"spam": "eggs"},
             [],
-            _tools={tool.name: {"discover": tool.discover,}},
-            _reporters={"discover": reporter.report,},
+            _tools={
+                tool.name: {
+                    "discover": tool.discover,
+                }
+            },
+            _reporters={
+                "discover": reporter.report,
+            },
         )
 
         self.assertEqual(