Remove feature deprecation manager (#15715)

Author: karthiknadig

news/3 Code Health/15714.md

@@ -0,0 +1 @@
+Removing old way of feature deprecation where we showed notification for each feature we deprecated.

src/client/common/featureDeprecationManager.ts

@@ -52,7 +52,6 @@ import { CryptoUtils } from './crypto';
 import { EditorUtils } from './editor';
 import { ExperimentsManager } from './experiments/manager';
 import { ExperimentService } from './experiments/service';
-import { FeatureDeprecationManager } from './featureDeprecationManager';
 import {
     ExtensionInsidersDailyChannelRule,
     ExtensionInsidersOffChannelRule,
@@ -115,7 +114,6 @@ import {
     IEditorUtils,
     IExperimentsManager,
     IExtensions,
-    IFeatureDeprecationManager,
     IInstaller,
     IPathUtils,
     IPersistentStateFactory,
@@ -194,7 +192,6 @@ export function registerTypes(serviceManager: IServiceManager) {
         TerminalActivationProviders.pipenv,
     );
     serviceManager.addSingleton<IToolExecutionPath>(IToolExecutionPath, PipEnvExecutionPath, ToolExecutionPath.pipenv);
-    serviceManager.addSingleton<IFeatureDeprecationManager>(IFeatureDeprecationManager, FeatureDeprecationManager);
 
     serviceManager.addSingleton<IAsyncDisposableRegistry>(IAsyncDisposableRegistry, AsyncDisposableRegistry);
     serviceManager.addSingleton<IMultiStepInputFactory>(IMultiStepInputFactory, MultiStepInputFactory);

src/client/common/serviceRegistry.ts

@@ -20,7 +20,6 @@ import {
 } from 'vscode';
 import { LanguageServerType } from '../activation/types';
 import { LogLevel } from '../logging/levels';
-import type { CommandsWithoutArgs } from './application/commands';
 import type { ExtensionChannels } from './insidersBuild/types';
 import type { InterpreterUri } from './installer/types';
 import { EnvironmentVariables } from './variables/types';
@@ -492,26 +491,6 @@ export interface IPythonExtensionBanner {
 }
 export const BANNER_NAME_PROPOSE_LS = 'ProposePylance';
 
-export type DeprecatedSettingAndValue = {
-    setting: string;
-    values?: unknown[];
-};
-
-export type DeprecatedFeatureInfo = {
-    doNotDisplayPromptStateKey: string;
-    message: string;
-    moreInfoUrl: string;
-    commands?: CommandsWithoutArgs[];
-    setting?: DeprecatedSettingAndValue;
-};
-
-export const IFeatureDeprecationManager = Symbol('IFeatureDeprecationManager');
-
-export interface IFeatureDeprecationManager extends Disposable {
-    initialize(): void;
-    registerDeprecation(deprecatedInfo: DeprecatedFeatureInfo): void;
-}
-
 export const IEditorUtils = Symbol('IEditorUtils');
 export interface IEditorUtils {
     getWorkspaceEditsFromPatch(originalContents: string, patch: string, uri: Uri): WorkspaceEdit;

src/client/common/types.ts

@@ -26,7 +26,6 @@ import {
     IDisposableRegistry,
     IExperimentService,
     IExperimentsManager,
-    IFeatureDeprecationManager,
     IOutputChannel,
 } from './common/types';
 import { noop } from './common/utils/misc';
@@ -208,10 +207,6 @@ async function activateLegacy(ext: ExtensionState): Promise<ActivationResult> {
         context.subscriptions.push(languages.registerDocumentRangeFormattingEditProvider(PYTHON, formatProvider));
     }
 
-    const deprecationMgr = serviceContainer.get<IFeatureDeprecationManager>(IFeatureDeprecationManager);
-    deprecationMgr.initialize();
-    context.subscriptions.push(deprecationMgr);
-
     context.subscriptions.push(new ReplProvider(serviceContainer));
 
     const terminalProvider = new TerminalProvider(serviceContainer);

src/client/extensionActivation.ts

@@ -31,7 +31,6 @@ import { CryptoUtils } from '../../client/common/crypto';
 import { EditorUtils } from '../../client/common/editor';
 import { ExperimentsManager } from '../../client/common/experiments/manager';
 import { ExperimentService } from '../../client/common/experiments/service';
-import { FeatureDeprecationManager } from '../../client/common/featureDeprecationManager';
 import {
     ExtensionInsidersDailyChannelRule,
     ExtensionInsidersOffChannelRule,
@@ -105,7 +104,6 @@ import {
     IExperimentService,
     IExperimentsManager,
     IExtensions,
-    IFeatureDeprecationManager,
     IFileDownloader,
     IHttpClient,
     IInstaller,
@@ -257,11 +255,6 @@ suite('Installer', () => {
             PipEnvActivationCommandProvider,
             TerminalActivationProviders.pipenv,
         );
-        ioc.serviceManager.addSingleton<IFeatureDeprecationManager>(
-            IFeatureDeprecationManager,
-            FeatureDeprecationManager,
-        );
-
         ioc.serviceManager.addSingleton<IAsyncDisposableRegistry>(IAsyncDisposableRegistry, AsyncDisposableRegistry);
         ioc.serviceManager.addSingleton<IMultiStepInputFactory>(IMultiStepInputFactory, MultiStepInputFactory);
         ioc.serviceManager.addSingleton<IImportTracker>(IImportTracker, ImportTracker);