Skip to content

Commit 978b896

Browse files
authored
Display description in kernel picker (#14196) (#169)
1 parent aaa1228 commit 978b896

File tree

1 file changed

+11
-5
lines changed

1 file changed

+11
-5
lines changed

src/client/datascience/notebook/kernelProvider.ts

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ class VSCodeNotebookKernelMetadata implements VSCNotebookKernel {
3434
constructor(
3535
public readonly label: string,
3636
public readonly description: string,
37+
public readonly detail: string,
3738
public readonly selection: Readonly<KernelConnectionMetadata>,
3839
public readonly isPreferred: boolean,
3940
private readonly kernelProvider: IKernelProvider
@@ -109,7 +110,8 @@ export class VSCodeKernelPickerProvider implements NotebookKernelProvider {
109110
const mapped = withInterpreter.map((kernel) => {
110111
return new VSCodeNotebookKernelMetadata(
111112
kernel.label,
112-
kernel.description || kernel.detail || '',
113+
kernel.description || '',
114+
kernel.detail || '',
113115
kernel.selection,
114116
areKernelConnectionsEqual(kernel.selection, preferredKernel),
115117
this.kernelProvider
@@ -135,7 +137,8 @@ export class VSCodeKernelPickerProvider implements NotebookKernelProvider {
135137
1,
136138
new VSCodeNotebookKernelMetadata(
137139
kernel.label,
138-
kernel.description || kernel.detail || '',
140+
kernel.description || '',
141+
kernel.detail || '',
139142
kernel.selection,
140143
true,
141144
this.kernelProvider
@@ -163,23 +166,26 @@ export class VSCodeKernelPickerProvider implements NotebookKernelProvider {
163166
return;
164167
} else if (preferredKernel.kind === 'startUsingPythonInterpreter') {
165168
return new VSCodeNotebookKernelMetadata(
166-
preferredKernel.interpreter?.displayName || preferredKernel.interpreter.path,
169+
preferredKernel.interpreter.displayName || preferredKernel.interpreter.path,
170+
'',
167171
preferredKernel.interpreter.path,
168172
preferredKernel,
169173
true,
170174
this.kernelProvider
171175
);
172176
} else if (preferredKernel.kind === 'connectToLiveKernel') {
173177
return new VSCodeNotebookKernelMetadata(
174-
preferredKernel.kernelModel?.display_name || preferredKernel.kernelModel?.name,
175-
preferredKernel.kernelModel?.name,
178+
preferredKernel.kernelModel.display_name || preferredKernel.kernelModel.name,
179+
'',
180+
preferredKernel.kernelModel.name,
176181
preferredKernel,
177182
true,
178183
this.kernelProvider
179184
);
180185
} else {
181186
return new VSCodeNotebookKernelMetadata(
182187
preferredKernel.kernelSpec.display_name,
188+
'',
183189
preferredKernel.kernelSpec.name,
184190
preferredKernel,
185191
true,

0 commit comments

Comments
 (0)