@@ -28,9 +28,7 @@ export class FeedbackService implements Disposable {
28
28
constructor ( persistentStateFactory : IPersistentStateFactory ) {
29
29
this . showFeedbackPrompt = persistentStateFactory . createGlobalPersistentState ( 'SHOW_FEEDBACK_PROMPT' , true ) ;
30
30
this . userResponded = persistentStateFactory . createGlobalPersistentState ( 'RESPONDED_TO_FEEDBACK' , false ) ;
31
- if ( this . showFeedbackPrompt . value && ! this . userResponded . value ) {
32
- this . initialize ( ) ;
33
- }
31
+ this . initialize ( ) ;
34
32
}
35
33
public dispose ( ) {
36
34
this . counters = undefined ;
@@ -44,6 +42,9 @@ export class FeedbackService implements Disposable {
44
42
// tslint:disable-next-line:no-void-expression
45
43
let commandDisable = commands . registerCommand ( 'python.updateFeedbackCounter' , ( telemetryEventName : string ) => this . updateFeedbackCounter ( telemetryEventName ) ) ;
46
44
this . disposables . push ( commandDisable ) ;
45
+ if ( ! this . showFeedbackPrompt . value || this . userResponded . value ) {
46
+ return ;
47
+ }
47
48
// tslint:disable-next-line:no-void-expression
48
49
commandDisable = workspace . onDidChangeTextDocument ( changeEvent => this . handleChangesToTextDocument ( changeEvent . document ) , this , this . disposables ) ;
49
50
this . disposables . push ( commandDisable ) ;
@@ -60,7 +61,8 @@ export class FeedbackService implements Disposable {
60
61
if ( ! this . canShowPrompt ) {
61
62
return ;
62
63
}
63
- this . counters . incrementEditCounter ( ) ;
64
+ // tslint:disable-next-line:no-non-null-assertion
65
+ this . counters ! . incrementEditCounter ( ) ;
64
66
}
65
67
private updateFeedbackCounter ( telemetryEventName : string ) : void {
66
68
// Ignore feedback events.
@@ -70,7 +72,8 @@ export class FeedbackService implements Disposable {
70
72
if ( ! this . canShowPrompt ) {
71
73
return ;
72
74
}
73
- this . counters . incrementFeatureUsageCounter ( ) ;
75
+ // tslint:disable-next-line:no-non-null-assertion
76
+ this . counters ! . incrementFeatureUsageCounter ( ) ;
74
77
}
75
78
private thresholdHandler ( ) {
76
79
if ( ! this . canShowPrompt ) {
0 commit comments