Ensure executableSpecified is set correctly (#18020)

karthiknadig · web-flow · commit f10e6a2a6b1e · 2021-11-12T15:47:08.000-08:00
diff --git a/news/3 Code Health/18019.md b/news/3 Code Health/18019.md
@@ -0,0 +1 @@
+Ensure telemetry correctly identifies when users set linter paths.
diff --git a/src/client/linters/lintingEngine.ts b/src/client/linters/lintingEngine.ts
@@ -140,7 +140,7 @@ export class LintingEngine implements ILintingEngine {
             tool: info.id,
             hasCustomArgs: info.linterArgs(resource).length > 0,
             trigger,
-            executableSpecified: linterExecutablePathName.length > 0,
+            executableSpecified: linterExecutablePathName !== info.id,
         };
         sendTelemetryWhenDone(EventName.LINTING, promise, stopWatch, properties);
     }

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Ensure telemetry correctly identifies when users set linter paths.`
Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ export class LintingEngine implements ILintingEngine {`
`140`	`140`	`tool: info.id,`
`141`	`141`	`hasCustomArgs: info.linterArgs(resource).length > 0,`
`142`	`142`	`trigger,`
`143`		`- executableSpecified: linterExecutablePathName.length > 0,`
	`143`	`+ executableSpecified: linterExecutablePathName !== info.id,`
`144`	`144`	`};`
`145`	`145`	`sendTelemetryWhenDone(EventName.LINTING, promise, stopWatch, properties);`
`146`	`146`	`}`