Skip to content

After updating to v2021.3.658691958 String.startsWith doesn't work properly in other extensions. #15744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexet opened this issue Mar 22, 2021 · 2 comments · Fixed by #15832
Assignees
Labels
area-editor-* User-facing catch-all bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority regression Bug didn't exist in a previous release

Comments

@alexet
Copy link

alexet commented Mar 22, 2021

In the minified js there is String.prototype.startsWith=function(e){return this.substring(0,e.length)===e}.

This breaks the 2 argument form globally across the whole extension host and in turn this breaks our extension.

Looking at the installed files I think it may be from here and I have filed an upstream report here.

@alexet alexet added triage-needed Needs assignment to the proper sub-team bug Issue identified by VS Code Team member as probable bug labels Mar 22, 2021
@karthiknadig karthiknadig self-assigned this Mar 22, 2021
@karthiknadig
Copy link
Member

@alexet Thanks for identifying the problem. We will update to the latest pidtree when they fix this.

@karthiknadig karthiknadig added area-editor-* User-facing catch-all needs PR labels Mar 22, 2021
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Mar 22, 2021
@karthiknadig karthiknadig added regression Bug didn't exist in a previous release and removed triage labels Mar 22, 2021
@luabud luabud added the important Issue identified as high-priority label Mar 24, 2021
@luabud
Copy link
Member

luabud commented Mar 31, 2021

We will remove the dependency on pidtree by not collecting jedi_memory stats anymore.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-editor-* User-facing catch-all bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority regression Bug didn't exist in a previous release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants