Skip to content

'Python: Run Linting' commands shows up in TS files #17243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mjbvz opened this issue Sep 1, 2021 · 8 comments
Closed

'Python: Run Linting' commands shows up in TS files #17243

mjbvz opened this issue Sep 1, 2021 · 8 comments
Labels
area-editor-* User-facing catch-all bug Issue identified by VS Code Team member as probable bug good first issue partner ask verification-found Issue verification failed

Comments

@mjbvz
Copy link

mjbvz commented Sep 1, 2021 •
edited
Loading

Issue Type: Bug

  1. In a fresh workspace that hasn't activated python
  2. Open a TS file
  3. Open command palette and search run
    🐛 The Python: Run Linting command shows up

Running this command produces an error:

Screen Shot 2021-09-01 at 3 42 39 PM

Extension version: 2021.10.1191770306-dev
VS Code version: Code - Insiders 1.60.0-insider (Universal) (e7d7e9a9348e6a8cc8c03f877d39cb72e5dfb1ff, 2021-09-01T10:39:32.559Z)
OS version: Darwin x64 20.6.0
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 3
Memory (System) 32.00GB (0.02GB free)
Process Argv --crash-reporter-id 48781ca2-1705-4f64-9bab-325055aab55d
Screen Reader no
VM 0%
A/B Experiments 
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
pythonvspyt602:30291494
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30291487
pythontb:30258533
pythonvspyt551cf:30291413
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
pythonvsuse255:30319630
vscod805cf:30301675
pythonvspyt200:30323110
vsccppwtct:30312693
pythonvssor306:30340298
bridge0708:30335490
pygetstartedt2:30353727
dockerwalkthrucf:30348714
bridge0723:30353136
pythonrunftest32:30353181
pythonf5test824:30353183
javagetstartedt:30350119
pythonvspyt187cf:30356035
pydsgsc2:30356658
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Sep 1, 2021
@karthiknadig karthiknadig added area-editor-* User-facing catch-all bug Issue identified by VS Code Team member as probable bug needs PR partner ask and removed triage-needed Needs assignment to the proper sub-team labels Sep 2, 2021
@karthiknadig karthiknadig added this to the September 2021 milestone Sep 2, 2021
@karrtikr
Copy link

Thanks for the bug report! We just wanted to quickly acknowledge we received it and we will triage this as soon as we can.

@karrtikr
Copy link

Fixed with #17698

@karrtikr karrtikr added the verification-needed Verification of issue is requested label Oct 25, 2021
@rchiodo rchiodo added the verified Verification succeeded label Oct 26, 2021
@rchiodo
Copy link

rchiodo commented Oct 26, 2021

/verified?

The command doesn't error anymore but seems odd that it is allowed in the first place. Could the when clause check the language?

@karrtikr karrtikr added verification-found Issue verification failed and removed verified Verification succeeded verification-needed Verification of issue is requested labels Oct 26, 2021
@karrtikr karrtikr reopened this Oct 26, 2021
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Oct 26, 2021
@karrtikr
Copy link

Yes, we should add editorLangId == python to all such commands.

@karrtikr karrtikr removed the triage-needed Needs assignment to the proper sub-team label Oct 26, 2021
@karrtikr karrtikr removed their assignment Oct 26, 2021
@karrtikr
Copy link

Closed as dup of #10441

@karrtikr karrtikr removed this from the November 2021 milestone Oct 30, 2021
@karrtikr karrtikr added this to the October 2021 milestone Oct 30, 2021
@alexr00
Copy link
Member

alexr00 commented Nov 1, 2021

I'm still seeing this with version v2021.11.1382879425-dev:

image

@alexr00 alexr00 reopened this Nov 1, 2021
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Nov 1, 2021
@karrtikr
Copy link

karrtikr commented Nov 1, 2021

This is closed in favor of the other issue, which has not been addressed yet.

@karrtikr karrtikr closed this as completed Nov 1, 2021
@alexr00
Copy link
Member

alexr00 commented Nov 1, 2021

@karrtikr removing from the October milestone since it was not addressed.

@alexr00 alexr00 removed this from the October 2021 milestone Nov 1, 2021
@karthiknadig karthiknadig removed the triage-needed Needs assignment to the proper sub-team label Nov 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-editor-* User-facing catch-all bug Issue identified by VS Code Team member as probable bug good first issue partner ask verification-found Issue verification failed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@karthiknadig @mjbvz @karrtikr @rchiodo @alexr00 @luabud