Skip to content

Localize strings on github.dev #17712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
karrtikr opened this issue Oct 12, 2021 · 1 comment · Fixed by #17711
Closed

Localize strings on github.dev #17712

karrtikr opened this issue Oct 12, 2021 · 1 comment · Fixed by #17711
Assignees
@karrtikr
Labels
area-internal Label for non-user facing issues feature-request Request for new features or functionality important Issue identified as high-priority
Milestone
September 2021 Re...

Comments

@karrtikr
Copy link

Change localization in the extension to use async VS Code FS APIs, as native node fs APIs are not available in browser. Some work done here: #17711
@karrtikr karrtikr added feature-request Request for new features or functionality needs PR important Issue identified as high-priority area-internal Label for non-user facing issues labels Oct 12, 2021
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Oct 12, 2021
@karrtikr karrtikr removed the triage-needed Needs assignment to the proper sub-team label Oct 12, 2021
@karrtikr karrtikr mentioned this issue Oct 12, 2021
Merged
@karrtikr
Copy link
Author

Converting the existing localize module to async is a problem as that means we cannot load any existing localized strings at module level in the extension. Two approaches:

  • Fix all localized constants in the extension to not be imported at module level.
  • Create a separate localization module for the browser case which used the VSCode API.

If first approach seems to take a long time, we should be going with the second approach.

@karrtikr karrtikr self-assigned this Oct 13, 2021
@karrtikr karrtikr added this to the September 2021 Recovery milestone Oct 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@karrtikr karrtikr

Labels
area-internal Label for non-user facing issues feature-request Request for new features or functionality important Issue identified as high-priority
Projects
None yet
Milestone
September 2021 Recovery
Development

Successfully merging a pull request may close this issue.

Localize strings on github.dev using VSCode FS API karrtikr/vscode-python
1 participant
@karrtikr