Skip to content

Test: Improve experience when an invalid Python interpreter is selected #19551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
karrtikr opened this issue Jul 25, 2022 · 2 comments
Closed
2 tasks done

Comments

@karrtikr
Copy link

karrtikr commented Jul 25, 2022

Refs: #19174

Complexity: 5

Create Issue


Requirements:

  • Pre-release version of the Python extension installed

Steps:

Intention is to verify no error prompts show up at startup, and only show up when user manually attempts to use a feature of an extension which requires an interpreter:

image

  • Select an invalid interpreter. You can use Python: Select Interpreter command and choose Enter interpreter path... item.
  • Verify prompt shows up.
  • Reload window.
  • Open a Python file to activate the extension. Verify no error prompts show up at startup.
  • Verify the following warning with appropriate theme color appears in the status bar:
    image
  • Try using any feature of the Python extension which requires a Python interpreter, and verify that the prompt to select interpreter shows up. Some of the important ones to verify:
    • Running python files in:
      • Terminal: Play icon on top right
      • REPL (Shift + Enter)
    • Debugging
    • Refactoring. For eg. "Sort Imports"
    • Linting
      image
    • Any Python: ... commands requiring an interpreter or anything in the context menu
@karrtikr karrtikr added the feature-request Request for new features or functionality label Jul 25, 2022
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jul 25, 2022
@karrtikr karrtikr added testplan-item and removed feature-request Request for new features or functionality triage-needed Needs assignment to the proper sub-team labels Jul 25, 2022
@karrtikr karrtikr changed the title Test: Improve experience when no Python interpreter is selected Test: Improve experience when an invalid Python interpreter is selected Jul 25, 2022
@ghost ghost assigned sandy081 and rchiodo Jul 26, 2022
@sandy081 sandy081 removed their assignment Jul 26, 2022
@rchiodo rchiodo removed their assignment Jul 26, 2022
@rchiodo
Copy link

rchiodo commented Jul 26, 2022

Not sure but it seems like the 'Hey this interpreter is bad' question is cached and also not shown before an action is run.

@rchiodo
Copy link

rchiodo commented Jul 26, 2022

Nope, my bad. I had the old extension installed.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants