formatOnType removes the space between string and brace on the last line of multiline f-string

[MisLink]

Environment data

• VS Code version: 1.25.1
• Extension version (available under the Extensions sidebar): 2018.7.1
• OS and version: macOS 10.13.6
• Python version (& distribution if applicable, e.g. Anaconda): CPython 3.6.6
• Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv
• Relevant/affected Python packages and their versions: N/A

Actual behavior

f"""
select * from {table}
where {condition}
order by {order_columns}
limit {limit_num};"""  # enter

then:

f"""
select * from {table}
where {condition}
order by {order_columns}
limit{limit_num}; """  # remove the space bwtween limit and {, and add a space at the end.

Expected behavior

Keep it as it is

Steps to reproduce:

1. paste the code and have a try.

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

N/A

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)

N/A

[ericsnowcurrently]

Hi @MisLink. Thanks for letting us know about this. We'll work on fixing it.

I was able to reproduce this on Ubuntu with Python 3.7 (under both Jedi and the new language server).

[DonJayamanne]

I was able to reproduce this on Ubuntu with Python 3.7 (under both Jedi and the new language server).

@ericsnowcurrently this is done within the typescript code in the extension, not part of the language server.

[MikhailArkhipov]

microsoft/python-language-server#5