Skip to content

Ensure all promises have exception handlers #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DonJayamanne opened this issue Nov 30, 2017 · 1 comment
Closed

Ensure all promises have exception handlers #327

DonJayamanne opened this issue Nov 30, 2017 · 1 comment
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.

Comments

@DonJayamanne
Copy link

This applies to commands and other VS Code API that return promises.

Note: We seem to have code within the extension where this happens today.
See #218 (comment)

UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): TypeError: Cannot read property 'SendExceptionInfo' of null
(node:6204) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
@DonJayamanne DonJayamanne added awaiting 2-PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. labels Nov 30, 2017
@DonJayamanne
Copy link
Author

Fixed with #228 (changes committed)

@brettcannon brettcannon mentioned this issue Nov 30, 2017
Closed
10 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jul 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brettcannon @DonJayamanne