Skip to content

Test Explorer continues to show tests as passing even if test modules can no longer be imported #6244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brettcannon opened this issue Jun 19, 2019 · 1 comment
Labels
area-testing bug Issue identified by VS Code Team member as probable bug

Comments

@brettcannon
Copy link
Member

I ran my tests and had them passing. Then I moved all of my logic code and broke my imports, but the Test Explorer continued to say my tests were passing. The following is an example of the failures pytest is reporting which are not being reflected in the Test Explorer (the status bar shows the right result):

=================================== ERRORS ====================================
______________ ERROR collecting tests/test_ghutils/test_ping.py _______________
ImportError while importing test module 'c:\Users\brcan\Repositories\pvscbot\tests\test_ghutils\test_ping.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests\test_ghutils\test_ping.py:7: in <module>
    from pvscbot.ghutils import ping
E   ModuleNotFoundError: No module named 'pvscbot.ghutils'
@brettcannon brettcannon added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team area-testing reason-preexisting labels Jun 19, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jun 20, 2019
@luabud
Copy link
Member

luabud commented Jul 8, 2020

Closing in favour of #4586.

@luabud luabud closed this as completed Jul 8, 2020
@ghost ghost removed the needs PR label Jul 8, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants