Skip to content

User linting settings do not work, workspace settings are backwards for pylint? #9863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
johntmyers opened this issue Feb 2, 2020 · 2 comments
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@johntmyers
Copy link

Issue Type: Bug

User settings for pylint are not working. If I have them disabled for Workspace but enabled for User, pylint does not run on my code. The behavior is much different from enabling/disabling other linters. So basically User level settings do not work.

How to reproduce:

  • User setting: Pylint Enabled is checked
  • Workspace setting:
    • Uncheck "Pylint Enabled" and "python.linting.pylintEnabled": false appears in settings.json
    • Check "Pylint Enabled" and "python.linting.pylintEnabled": false disappears in settings.json

This is backwards behavior from how, for example, flake8 works. If I check "enable flake8" in settings, I get: "python.linting.flake8Enabled": true in the settings.json. However, if I do uncheck flake8 in workspace settings, my User settings still do not work.

VS Code version: Code 1.41.1 (26076a4de974ead31f97692a0d32f90d735645c0, 2019-12-18T14:57:51.166Z)
OS version: Darwin x64 19.2.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz (12 x 2600)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off
surface_control: disabled_off
surface_synchronization: enabled_on
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 16.00GB (0.16GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (2)
Extension Author (truncated) Version
vscode-docker ms- 0.10.0
python ms- 2020.1.58038
@johntmyers johntmyers added triage-needed Needs assignment to the proper sub-team bug Issue identified by VS Code Team member as probable bug labels Feb 2, 2020
@ghost
Copy link

ghost commented Feb 4, 2020

Yes, it's a known issue after 2020.1.0 update of this extension. Unless you declare "python.linting.pylint": true in settings.json, pylint doesn't work.

Duplicate of #9778, #9637 , #9649

Bug also affected #9577

Similar to: microsoft/python-language-server#1868

Relevant #7314

Possible cause #7314 (comment)

@karthiknadig
Copy link
Member

Closing in favor of #9649

@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Feb 4, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants