Skip to content

Commit 43ea275

Browse files
committed
docs: prep for 2.3.4
1 parent d1668ff commit 43ea275

File tree

2 files changed

+15
-14
lines changed

2 files changed

+15
-14
lines changed

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
### 2.3.4 | 2022-07-31
4+
5+
- Fix "insiders" string not matching correctly
6+
37
### 2.3.3 | 2022-06-10
48

59
- Disable GPU sandbox by default, fixing failures in some CI's.

lib/util.ts

+11-14
Original file line numberDiff line numberDiff line change
@@ -28,16 +28,16 @@ switch (process.platform) {
2828
process.arch === 'arm64'
2929
? 'win32-arm64-archive'
3030
: process.arch === 'ia32'
31-
? 'win32-archive'
32-
: 'win32-x64-archive';
31+
? 'win32-archive'
32+
: 'win32-x64-archive';
3333
break;
3434
default:
3535
systemDefaultPlatform =
3636
process.arch === 'arm64' ? 'linux-arm64' : process.arch === 'arm' ? 'linux-armhf' : 'linux-x64';
3737
}
3838

3939
export function isInsiderVersionIdentifier(version: string): boolean {
40-
return version === 'insiders' || version.endsWith('-insider'); // insider or 1.2.3-insider version string
40+
return version === 'insiders' || version === 'insider' || version.endsWith('-insider'); // insider or 1.2.3-insider version string
4141
}
4242

4343
export function isStableVersionIdentifier(version: string): boolean {
@@ -242,19 +242,16 @@ export function killTree(processId: number, force: boolean) {
242242

243243
// when killing a process in Windows its child processes are *not* killed but become root processes.
244244
// Therefore we use TASKKILL.EXE
245-
cp = spawn(path.join(windir, 'System32', 'taskkill.exe'), [
246-
...force ? ['/F'] : [],
247-
'/T',
248-
'/PID',
249-
processId.toString(),
250-
], { stdio: 'inherit' });
245+
cp = spawn(
246+
path.join(windir, 'System32', 'taskkill.exe'),
247+
[...(force ? ['/F'] : []), '/T', '/PID', processId.toString()],
248+
{ stdio: 'inherit' }
249+
);
251250
} else {
252251
// on linux and OS X we kill all direct and indirect child processes as well
253-
cp = spawn('sh', [
254-
path.resolve(__dirname, '../killTree.sh'),
255-
processId.toString(),
256-
force ? '9' : '15',
257-
], { stdio: 'inherit' });
252+
cp = spawn('sh', [path.resolve(__dirname, '../killTree.sh'), processId.toString(), force ? '9' : '15'], {
253+
stdio: 'inherit',
254+
});
258255
}
259256

260257
return new Promise<void>((resolve, reject) => {

0 commit comments

Comments
 (0)